Bug 34408

Summary: check-webkit-style: Separate the filter code into a separate file
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 33684    
Attachments:
Description Flags
Proposed patch
cjerdonek: commit-queue-
Proposed patch none

Chris Jerdonek
Reported 2010-01-31 22:03:15 PST
This is preparatory refactoring for-- https://bugs.webkit.org/show_bug.cgi?id=33684 (In the fix for bug 33684, we will be introducing another filter-related class into this new file.)
Attachments
Proposed patch (15.92 KB, patch)
2010-02-01 18:34 PST, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (16.36 KB, patch)
2010-02-01 22:55 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-02-01 18:34:21 PST
Created attachment 47897 [details] Proposed patch This is just moving code. cq- since I may need to rebase after the following goes in-- https://bugs.webkit.org/show_bug.cgi?id=34260 (I'd like to wait until that one goes in before committing this one.)
Chris Jerdonek
Comment 2 2010-02-01 22:55:20 PST
Created attachment 47907 [details] Proposed patch After rebasing.
Chris Jerdonek
Comment 3 2010-02-02 07:29:01 PST
Comment on attachment 47907 [details] Proposed patch Clearing flags on attachment: 47907 Committed r54234: <http://trac.webkit.org/changeset/54234>
Chris Jerdonek
Comment 4 2010-02-02 07:29:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.