Summary: | Screen.availLeft should be signed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | DOM | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, sam, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-01-31 11:21:19 PST
Screen.availLeft and Screen.availTop should be *signed* Created attachment 70275 [details]
Patch
Comment on attachment 70275 [details]
Patch
+int Screen::availLeft() const
{
if (!m_frame)
return 0;
return static_cast<unsigned>(screenAvailableRect(m_frame->view()).x());
Why cast to unsigned?
Created attachment 70278 [details]
Patch
Fixed the casts. Comment on attachment 70278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70278&action=review r=me > WebCore/manual-tests/screen-availLeft.html:5 > + <script type="text/javascript" charset="utf-8"> Charset is useless for inline scripts. But it's fine to land as is to make sure it's not causing a crash somewhere. > WebCore/manual-tests/screen-availLeft.html:11 > + function log(s) > + { > + var output = document.getElementById('output'); > + output.innerHTML += s + "<br>"; > + } That's a lot of code for one lag() call. |