Bug 34397 – Screen.availLeft should be signed

• Component: DOM
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Screen.availLeft and Screen.availTop should be unsigned, since they can be negative for screens to the left of/above the primary screen.

[Simon Fraser (smfr)]

Screen.availLeft and Screen.availTop should be *signed*

[Simon Fraser (smfr)]

Created attachment 70275 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 70275 [details]
Patch

+int Screen::availLeft() const
 {
     if (!m_frame)
         return 0;
     return static_cast<unsigned>(screenAvailableRect(m_frame->view()).x());

Why cast to unsigned?

[Simon Fraser (smfr)]

Created attachment 70278 [details]
Patch

[Simon Fraser (smfr)]

Fixed the casts.

[Alexey Proskuryakov]

Comment on attachment 70278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70278&action=review

r=me

> WebCore/manual-tests/screen-availLeft.html:5
> +    <script type="text/javascript" charset="utf-8">

Charset is useless for inline scripts. But it's fine to land as is to make sure it's not causing a crash somewhere.

> WebCore/manual-tests/screen-availLeft.html:11
> +        function log(s)
> +        {
> +            var output = document.getElementById('output');
> +            output.innerHTML += s + "<br>";
> +        }

That's a lot of code for one lag() call.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/69599