Bug 34380

Summary: [WINCE] Buildfix for ThreadSpecific.h
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
The patch none

Patrick R. Gansterer
Reported 2010-01-30 14:38:11 PST
see patch
Attachments
The patch (1.73 KB, patch)
2010-01-30 14:38 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-01-30 14:38:58 PST
Created attachment 47776 [details] The patch
Darin Adler
Comment 2 2010-01-31 19:47:36 PST
Comment on attachment 47776 [details] The patch > +// TLS_OUT_OF_INDEXES is not defined on WinCE. > +#ifndef TLS_OUT_OF_INDEXES > +#define TLS_OUT_OF_INDEXES 0xffffffff > +#endif I guess this is OK, but I don't see any check for WinCE here. Might be slightly better to explicitly use a WINCE ifdef so we’d get a warning instead of just using the wrong value if someone made a mistake and did not get the TLS_OUT_OF_INDEXES constant. > - DWORD tls_key = TlsAlloc(); > - if (tls_key == TLS_OUT_OF_INDEXES) > + DWORD tlsKey = TlsAlloc(); > + if (tlsKey == TLS_OUT_OF_INDEXES) > CRASH(); > > m_index = InterlockedIncrement(&tlsKeyCount()) - 1; > if (m_index >= kMaxTlsKeySize) > CRASH(); > - tlsKeys()[m_index] = tls_key; > + tlsKeys()[m_index] = tlsKey; The unrelated style change really does not belong on the same patch.
WebKit Commit Bot
Comment 3 2010-01-31 20:23:11 PST
Comment on attachment 47776 [details] The patch Clearing flags on attachment: 47776 Committed r54123: <http://trac.webkit.org/changeset/54123>
WebKit Commit Bot
Comment 4 2010-01-31 20:23:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.