Summary: | [WINCE] Buildfix for ThreadSpecific.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Other | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-01-30 14:38:11 PST
Created attachment 47776 [details]
The patch
Comment on attachment 47776 [details] The patch > +// TLS_OUT_OF_INDEXES is not defined on WinCE. > +#ifndef TLS_OUT_OF_INDEXES > +#define TLS_OUT_OF_INDEXES 0xffffffff > +#endif I guess this is OK, but I don't see any check for WinCE here. Might be slightly better to explicitly use a WINCE ifdef so we’d get a warning instead of just using the wrong value if someone made a mistake and did not get the TLS_OUT_OF_INDEXES constant. > - DWORD tls_key = TlsAlloc(); > - if (tls_key == TLS_OUT_OF_INDEXES) > + DWORD tlsKey = TlsAlloc(); > + if (tlsKey == TLS_OUT_OF_INDEXES) > CRASH(); > > m_index = InterlockedIncrement(&tlsKeyCount()) - 1; > if (m_index >= kMaxTlsKeySize) > CRASH(); > - tlsKeys()[m_index] = tls_key; > + tlsKeys()[m_index] = tlsKey; The unrelated style change really does not belong on the same patch. Comment on attachment 47776 [details] The patch Clearing flags on attachment: 47776 Committed r54123: <http://trac.webkit.org/changeset/54123> All reviewed patches have been landed. Closing bug. |