Bug 3436

Summary:

Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields]

Product:

WebKit

Reporter:

Stéphane Corthésy <stephane-odb>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Blocker

Priority:

Version:

412

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch to fix 3436	darin: review+

Stéphane Corthésy

Reported 2005-06-11 08:09:50 PDT

In WebKit/Misc.subproj/WebNSDataExtras.m version 1.4, method -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields] declared in corresponding header file is missing an implementation; actually implementation is there, but wrongly named -[NSData(WebNSDateExtras) _web_parseRFC822HeaderFields] Simply renaming method fixes problem, as wrong method name is used nowhere in WebKit, whereas correct method name is. BTW, shouldn't category be named WebNSDataExtras instead of WebNSDateExtras??

Attachments
Patch to fix 3436 (1.12 KB, patch) 2005-06-20 22:21 PDT, Michael Gaiman	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Gaiman

Comment 1 2005-06-20 22:21:08 PDT

Created attachment 2522 [details] Patch to fix 3436 This is a straightforward patch, but I figured if I did it, it might save someone a couple minutes.

Darin Adler

Comment 2 2005-06-22 09:32:23 PDT

The "NSDate" typo in the header is the reason this wasn't caught at compile time. I'll fix that too.

Note You need to log in before you can comment on or make changes to this bug.