Bug 34346

Summary: With JSC bindings, make processingUserGesture work with events in Isolated Worlds.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore JavaScriptAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, dglazkov, eric, hamaji, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The Patch oliver: review+

Gavin Barraclough
Reported 2010-01-29 14:31:44 PST
Presently the check only looks to see if the handler is registered for the normal world.
Attachments
The Patch (24.95 KB, patch)
2010-01-29 14:44 PST, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-01-29 14:44:41 PST
Created attachment 47737 [details] The Patch
WebKit Review Bot
Comment 2 2010-01-29 14:46:25 PST
Attachment 47737 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/218870
Adam Roben (:aroben)
Comment 3 2010-01-29 14:48:48 PST
I think Sam should probably review this.
Adam Barth
Comment 4 2010-01-29 17:44:41 PST
This patch doesn't appear to have any tests.
Gavin Barraclough
Comment 5 2010-01-29 17:54:20 PST
(In reply to comment #4) > This patch doesn't appear to have any tests. Sam spotted that too, d'oh :-D – working on it!
Oliver Hunt
Comment 6 2010-02-01 12:37:43 PST
Comment on attachment 47737 [details] The Patch r=me, all this patch needs is tests :D
Gavin Barraclough
Comment 7 2010-02-01 17:20:51 PST
Transmitting file data ............................ Committed revision 54182.
Eric Seidel (no email)
Comment 8 2010-02-01 20:33:40 PST
It appears this broke Chromium: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/1732/steps/compile-webkit/logs/stdio (As the EWS bots told us it would).
Gavin Barraclough
Comment 9 2010-02-02 14:25:24 PST
Ooop, sorry I missed that, sorry for the breakage. :o( Glad it was a trivial fix.
Note You need to log in before you can comment on or make changes to this bug.