Bug 34342

Summary: A first step towards the Indexed Database API
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, dglazkov, fishd, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+, dglazkov: commit-queue-

Description Jeremy Orlow 2010-01-29 13:01:51 PST 
A first step towards the Indexed Database API
Comment 1 Jeremy Orlow 2010-01-29 13:06:12 PST 
Created attachment 47730 [details]
Patch
Comment 2 Nate Chapin 2010-01-29 13:43:02 PST 
Comment on attachment 47730 [details]
Patch

One comment:

> +    if (args.Length() < 2)
> +        return throwError(V8Proxy::TypeError);

Should we match http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp#L452 and throw a SyntaxError with a similar error message?
Comment 3 Dimitri Glazkov (Google) 2010-01-29 14:17:56 PST 
Comment on attachment 47730 [details]
Patch

What is the difference between IDBDatabaseError and SQLError? They look really, really similar. Any way we could reuse one in place of another? Ditto with IDatabaseException.

The SYNTAX_ERROR change Nate suggested is good too.
Comment 4 Dimitri Glazkov (Google) 2010-01-29 14:22:44 PST 
Comment on attachment 47730 [details]
Patch

I think it shouldn't stop the patch from landing though. r=me after Nate's rename.
Comment 5 Jeremy Orlow 2010-01-29 14:25:26 PST 
(In reply to comment #4)
> (From update of attachment 47730 [details])
> I think it shouldn't stop the patch from landing though. r=me after Nate's
> rename.

Rename done.  Would rather combine the 2 IDLs only if the specs themselves do (maybe a common interface could be specced in the HTML spec?).
Comment 6 Jeremy Orlow 2010-01-29 16:19:23 PST 
Committed r54085: <http://trac.webkit.org/changeset/54085>