Bug 34342

Summary: A first step towards the Indexed Database API
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, dglazkov, fishd, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+, dglazkov: commit-queue-

Jeremy Orlow
Reported 2010-01-29 13:01:51 PST
A first step towards the Indexed Database API
Attachments
Patch (52.27 KB, patch)
2010-01-29 13:06 PST, Jeremy Orlow 		dglazkov: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-01-29 13:06:12 PST
Created attachment 47730 [details] Patch
Nate Chapin
Comment 2 2010-01-29 13:43:02 PST
Comment on attachment 47730 [details] Patch One comment: > + if (args.Length() < 2) > + return throwError(V8Proxy::TypeError); Should we match http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp#L452 and throw a SyntaxError with a similar error message?
Dimitri Glazkov (Google)
Comment 3 2010-01-29 14:17:56 PST
Comment on attachment 47730 [details] Patch What is the difference between IDBDatabaseError and SQLError? They look really, really similar. Any way we could reuse one in place of another? Ditto with IDatabaseException. The SYNTAX_ERROR change Nate suggested is good too.
Dimitri Glazkov (Google)
Comment 4 2010-01-29 14:22:44 PST
Comment on attachment 47730 [details] Patch I think it shouldn't stop the patch from landing though. r=me after Nate's rename.
Jeremy Orlow
Comment 5 2010-01-29 14:25:26 PST
(In reply to comment #4) > (From update of attachment 47730 [details]) > I think it shouldn't stop the patch from landing though. r=me after Nate's > rename. Rename done. Would rather combine the 2 IDLs only if the specs themselves do (maybe a common interface could be specced in the HTML spec?).
Jeremy Orlow
Comment 6 2010-01-29 16:19:23 PST
Committed r54085: <http://trac.webkit.org/changeset/54085>
Note You need to log in before you can comment on or make changes to this bug.