|Summary:||A first step towards the Indexed Database API|
|Product:||WebKit||Reporter:||Jeremy Orlow <jorlow>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||andreip, dglazkov, fishd, japhet|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Jeremy Orlow 2010-01-29 13:01:51 PST
A first step towards the Indexed Database API
Comment 2 Nate Chapin 2010-01-29 13:43:02 PST
Comment on attachment 47730 [details] Patch One comment: > + if (args.Length() < 2) > + return throwError(V8Proxy::TypeError); Should we match http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp#L452 and throw a SyntaxError with a similar error message?
Comment 3 Dimitri Glazkov (Google) 2010-01-29 14:17:56 PST
Comment on attachment 47730 [details] Patch What is the difference between IDBDatabaseError and SQLError? They look really, really similar. Any way we could reuse one in place of another? Ditto with IDatabaseException. The SYNTAX_ERROR change Nate suggested is good too.
Comment 4 Dimitri Glazkov (Google) 2010-01-29 14:22:44 PST
Comment on attachment 47730 [details] Patch I think it shouldn't stop the patch from landing though. r=me after Nate's rename.
Comment 5 Jeremy Orlow 2010-01-29 14:25:26 PST
(In reply to comment #4) > (From update of attachment 47730 [details]) > I think it shouldn't stop the patch from landing though. r=me after Nate's > rename. Rename done. Would rather combine the 2 IDLs only if the specs themselves do (maybe a common interface could be specced in the HTML spec?).