Bug 34269

Summary: Web Inspector: Use platform-specific fonts for SourceFrame contents
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed solution
none
[PATCH] Comments addressed pfeldman: review+

Description Alexander Pavlov (apavlov) 2010-01-28 08:50:33 PST
SourceFrame contents should use the same platform-specific fonts as those defined in https://bugs.webkit.org/show_bug.cgi?id=34040
Comment 1 Alexander Pavlov (apavlov) 2010-01-29 05:22:11 PST
Created attachment 47706 [details]
[PATCH] Proposed solution
Comment 2 Pavel Feldman 2010-01-29 05:28:23 PST
Comment on attachment 47706 [details]
[PATCH] Proposed solution

>      this._textModel = textModel;
>      this._textModel.changeListener = this._textChanged.bind(this);
> +    if (!WebInspector.TextEditor.PlatformFonts) {
> +        WebInspector.TextEditor.PlatformFonts = {};
> +        WebInspector.TextEditor.PlatformFonts[WebInspector.OS.Windows] = {size: 12, face: "Lucida Console"};
> +        WebInspector.TextEditor.PlatformFonts[WebInspector.OS.WindowsVistaOrLater] = {size: 12, face: "Courier"};
> +        WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacSnowLeopard] = {size: 11, face: "Menlo"};
> +        WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacLeopard] = {size: 10, face: "Monaco"};
> +        WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacTiger] = {size: 10, face: "Monaco"};
> +    }
> +

should this be defined in init font?


> +    this._isMac = platform === WebInspector.OS.MacTiger || platform === WebInspector.OS.MacLeopard || platform === WebInspector.OS.MacSnowLeopard;
>  

indexOf("mac") === 0?


> +            const fontMetrics = WebInspector.TextEditor.PlatformFonts[platform] || {size: 10, face: "monospace"};

fontInfo?
Comment 3 Alexander Pavlov (apavlov) 2010-01-29 05:56:44 PST
Created attachment 47708 [details]
[PATCH] Comments addressed
Comment 4 Pavel Feldman 2010-01-29 06:11:12 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/inspector.js
Committed r54059