Bug 34250 – Web Inspector: Add navigation items into the Elements panel context menu.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

There should be context menu actions offering to open resource in resources panel and/or in a separate tab when invoked on an URL.

[Alexander Pavlov (apavlov)]

Created attachment 67023 [details]
[PATCH] Suggested solution

The following items are added at the top of context menu for URLs in the Elements panel (DOM tree and url(...) property values in the Styles sidebar pane):

Open Link in New Window
Open Link in Resources Panel

The latter item is only added if the respective URL denotes a resource present in the Resources panel.

[Alexander Pavlov (apavlov)]

Created attachment 67024 [details]
[PATCH] Patch with localizedStrings.js diff

[Yury Semikhatsky]

Comment on attachment 67024 [details]
[PATCH] Patch with localizedStrings.js diff

View in context: https://bugs.webkit.org/attachment.cgi?id=67024&action=prettypatch

> WebCore/ChangeLog:5
> +        Web Inspector: Add navigation items into the Elements panel context menu.
Please provide detailed description of the added actions.

> WebCore/inspector/front-end/ElementsTreeOutline.js:293
> +            var needSeparator = true;
Please declare this variable outside the if block.

> WebCore/inspector/front-end/StylesSidebarPane.js:130
> +        // Keep these consistent with those added in WebInspector.ElementsTreeElement.prototype._populateHrefContextMenu().
This code is exactly the same in both places. Please extract it into a utility function or reassign WebInspector.ElementsTreeElement.prototype._populateHrefContextMenu function to WebInspector.StylesSidebarPane.prototype._populateHrefContextMenu like we do in some other places. Personally I'd prefer the former approach. r- for this.

[Alexander Pavlov (apavlov)]

Created attachment 67032 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Created attachment 67051 [details]
[PATCH] Rebase + style fix

[Yury Semikhatsky]

Comment on attachment 67051 [details]
[PATCH] Rebase + style fix

View in context: https://bugs.webkit.org/attachment.cgi?id=67051&action=prettypatch

> WebCore/inspector/front-end/StylesSidebarPane.js:120
> +    _populateHrefContextMenu: function(contextMenu, event, anchorElement)
Please remove this before landing.

[WebKit Review Bot]

http://trac.webkit.org/changeset/67191 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67183
http://trac.webkit.org/changeset/67191

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/English.lproj/localizedStrings.js
        M       WebCore/inspector/front-end/ElementsPanel.js
        M       WebCore/inspector/front-end/ElementsTreeOutline.js
        M       WebCore/inspector/front-end/StylesSidebarPane.js
        M       WebCore/inspector/front-end/inspector.js
Committed r67191