Bug 34232

Summary: Add addUserScript support to chromium port
Product: WebKit Reporter: Matt Perry <mpcomplete>
Component: PlatformAssignee: Matt Perry <mpcomplete>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
adds addUserScript to the API
none
fixed style issues eric: review+, eric: commit-queue-

Matt Perry
Reported 2010-01-27 16:50:10 PST
This is to fix some failing layout tests.
Attachments
adds addUserScript to the API (4.76 KB, patch)
2010-01-27 16:50 PST, Matt Perry 		no flags
DetailsFormatted DiffDiff
fixed style issues (4.72 KB, patch)
2010-01-27 18:02 PST, Matt Perry 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Perry
Comment 1 2010-01-27 16:50:44 PST
Created attachment 47575 [details] adds addUserScript to the API
WebKit Review Bot
Comment 2 2010-01-27 16:55:34 PST
Attachment 47575 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/src/WebViewImpl.cpp:1702: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
Matt Perry
Comment 3 2010-01-27 18:02:39 PST
Created attachment 47584 [details] fixed style issues
Eric Seidel (no email)
Comment 4 2010-02-01 12:53:07 PST
Comment on attachment 47584 [details] fixed style issues TODO should be a FIXME in WebKit. Otherwise looks fine.
Matt Perry
Comment 5 2010-02-01 14:44:22 PST
Committed: http://trac.webkit.org/changeset/54152
Note You need to log in before you can comment on or make changes to this bug.