Bug 34211

Summary: [V8] Support getting integer-named properties using indexing notation on document object
Product: WebKit Reporter: Mads Ager <ager>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Add indexed property getter to HTMLDocument objects none

Mads Ager
Reported 2010-01-27 05:06:53 PST
The V8 binding layer does not handle access of properties with integer names on HTMLDocuments as illustrated by the following example. We need to add an indexed property getter to HTMLDocuments. <html> <head> <script> function runTest() { alert(document['42']); alert(document[42]); } </script> </head> <body onload="runTest()"> <img name="42" src="foo.gif"> </body> </html>
Attachments
Add indexed property getter to HTMLDocument objects (4.50 KB, patch)
2010-01-27 05:19 PST, Mads Ager 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mads Ager
Comment 1 2010-01-27 05:07:17 PST
Corresponding Chromium bug: crbug.com/31662
Mads Ager
Comment 2 2010-01-27 05:19:12 PST
Created attachment 47520 [details] Add indexed property getter to HTMLDocument objects
Dimitri Glazkov (Google)
Comment 3 2010-01-27 08:42:12 PST
Nate, you want to give it a look-over?
Nate Chapin
Comment 4 2010-01-27 09:13:27 PST
(In reply to comment #3) > Nate, you want to give it a look-over? LGTM
Dimitri Glazkov (Google)
Comment 5 2010-01-27 09:19:22 PST
Comment on attachment 47520 [details] Add indexed property getter to HTMLDocument objects I wonder if we should just generate fallback index getters for all interfaces that have named property getters?
WebKit Commit Bot
Comment 6 2010-01-27 12:00:23 PST
Comment on attachment 47520 [details] Add indexed property getter to HTMLDocument objects Clearing flags on attachment: 47520 Committed r53946: <http://trac.webkit.org/changeset/53946>
WebKit Commit Bot
Comment 7 2010-01-27 12:00:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.