Bug 34210 – [Qt] Display page loading progress inside the QtLauncher location bar

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Andreas Kling]

[Qt] Display page loading progress inside the QtLauncher location bar

[Andreas Kling]

Created attachment 47514 [details]
Patch

[Simon Hausmann]

Comment on attachment 47514 [details]
Patch


> +class LocationEdit : public QLineEdit {
> +    Q_OBJECT
> +public:
> +    LocationEdit(QWidget *parent = 0)

Coding style: * placement is wrong.

> +protected:
> +    virtual void paintEvent(QPaintEvent *event)

Ditto.


> +#ifndef Q_WS_MAEMO_5
>          statusBar()->showMessage(link);
> +#endif
>  #ifndef QT_NO_TOOLTIP
>          if (!toolTip.isEmpty())
>              QToolTip::showText(QCursor::pos(), toolTip);
> @@ -410,7 +453,9 @@ protected slots:
>              QWebElementCollection result =  view->page()->mainFrame()->findAllElements(str);
>              foreach (QWebElement e, result)
>                  e.setStyleProperty("background-color", "yellow");
> +#ifndef Q_WS_MAEMO_5
>              statusBar()->showMessage(QString("%1 element(s) selected").arg(result.count()), 5000);
> +#endif

While I agree with the above two hunks (the flicker in the status bar is annoying), but technically that's unrelated to the progress bar stuff, no?

I suggest to mention it at least in the changelog.


The rest looks good to me :)

[Andreas Kling]

Created attachment 47709 [details]
Patch, issues addressed + LocationEdit class moved to its own file

[Andreas Kling]

Created attachment 47710 [details]
Same patch, one accidental \t expanded

[WebKit Review Bot]

Attachment 47710 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/locationedit.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Created attachment 47714 [details]
Same patch yet again, style issue fixed

[WebKit Review Bot]

Attachment 47714 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/locationedit.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 47714 [details]
Same patch yet again, style issue fixed

Clearing flags on attachment: 47714

Committed r54065: <http://trac.webkit.org/changeset/54065>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.