Summary: | CSS 'page-break-inside' property should be 'non-inherited' property. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, hamaji, hayato, webkit.review.bot, yuzo | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
URL: | http://www.w3.org/TR/CSS2/page.html#page-break-props | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 34080 | ||||||||||
Attachments: |
|
Description
Hayato Ito
2010-01-26 20:10:01 PST
Created attachment 47490 [details]
page-break-inside-non-inherited
Attachment 47490 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/style/RenderStyle.h:222: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 47491 [details]
page-break-inside-non-inherited-style-fixed
I fixed the style issue for my change. The file, RenderStyle.h, has other style errors where I've not touched. I left them as is. If it is better to correct the other style errors, please let me know it. Comment on attachment 47491 [details] page-break-inside-non-inherited-style-fixed > + return (_effectiveDisplay == other._effectiveDisplay) If you're reformatting this, I suggest removing the unneeded parentheses as well. This change needs a test case. review- because of the lack of a test case. Test case could involve getComputedStyle. Created attachment 47599 [details]
page-break-inside-add-test
Thank you for the review! I've removed the unneeded parentheses and added a test case. Comment on attachment 47599 [details]
page-break-inside-add-test
cq+
Comment on attachment 47599 [details] page-break-inside-add-test Clearing flags on attachment: 47599 Committed r54045: <http://trac.webkit.org/changeset/54045> All reviewed patches have been landed. Closing bug. |