Bug 34191

Summary: DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: sfalken, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Crash log.
Patch. sfalken: review+, dimich: commit-queue-

Description Dmitry Titov 2010-01-26 17:02:58 PST
Created attachment 47465 [details]
Crash log.

DRT crashes dereferencing 0 pointer (see attached crash report). This happens a few times during run-webkit-test, no bad diagnostics but it makes the run longer because it waits on ReportCrash.

Since Page can be created with 0 geolocationControllerClient, it seems the simple fix is to add 0 check. Patch is coming.
Comment 1 Simon Fraser (smfr) 2010-01-26 17:05:05 PST
Comment 2 Dmitry Titov 2010-01-26 17:06:21 PST
to reproduce, run: 
run-webkit-tests  LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
Comment 3 Dmitry Titov 2010-01-26 17:09:21 PST
Created attachment 47469 [details]
Comment 4 Dmitry Titov 2010-01-26 17:25:06 PST
Landed: http://trac.webkit.org/changeset/53876