Summary: | DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | sfalken, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
to reproduce, run: run-webkit-tests LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg Created attachment 47469 [details]
Patch.
|
Created attachment 47465 [details] Crash log. DRT crashes dereferencing 0 pointer (see attached crash report). This happens a few times during run-webkit-test, no bad diagnostics but it makes the run longer because it waits on ReportCrash. Since Page can be created with 0 geolocationControllerClient, it seems the simple fix is to add 0 check. Patch is coming.