Bug 34168

Summary:

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit Qt

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ariya.hidayat, benjamin, commit-queue, hausmann, ismail, kenneth, skyul

Priority:

Keywords:

Performance, Qt

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

34208

Attachments:

Description	Flags
Enable the #define for Maemo 5, Qt Embedded and Symbian	none
Enable it for Windows CE	kenneth: review+, kenneth: commit-queue+

Benjamin Poulain

Reported 2010-01-26 08:43:10 PST

https://bugs.webkit.org/show_bug.cgi?id=33408 introduces FAST_MOBILE_SCROLLING to disabled fixed background on embedded. Qt Webkit could define that as well for its embedded platforms.

Attachments
Enable the #define for Maemo 5, Qt Embedded and Symbian (1013 bytes, patch) 2010-01-26 08:46 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Enable it for Windows CE (917 bytes, patch) 2010-02-01 00:13 PST, Benjamin Poulain	kenneth: review+ kenneth: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2010-01-26 08:46:18 PST

Created attachment 47414 [details] Enable the #define for Maemo 5, Qt Embedded and Symbian

Kenneth Rohde Christiansen

Comment 2 2010-01-26 08:51:00 PST

We have to define if this is really what we want, as it changes the behaviour. Current iPhone and Android doesn't do anything like this, so this might be problematic.

Benjamin Poulain

Comment 3 2010-01-26 11:09:59 PST

(In reply to comment #2) > We have to define if this is really what we want, as it changes the behaviour. > Current iPhone and Android doesn't do anything like this, so this might be > problematic. I might be wrong but I had the impression they were using a virtual viewport of the size of the content. This would essentially give the same results. Do you have one of those devices to check?

Eric Seidel (no email)

Comment 4 2010-01-26 14:00:09 PST

Comment on attachment 47414 [details] Enable the #define for Maemo 5, Qt Embedded and Symbian OK, i trust you.

Eric Seidel (no email)

Comment 5 2010-01-26 14:00:49 PST

Comment on attachment 47414 [details] Enable the #define for Maemo 5, Qt Embedded and Symbian Hmm... I'll leave a qter to decide if this should actually be committed.

Benjamin Poulain

Comment 6 2010-01-27 01:45:30 PST

(In reply to comment #2) > We have to define if this is really what we want, as it changes the behaviour. > Current iPhone and Android doesn't do anything like this, so this might be > problematic. Andreas just tested that on an iPhone, this gives the same behavior. The way to achieve that is different as I mentioned.

Ariya Hidayat

Comment 7 2010-01-31 06:59:16 PST

I agree. We should certainly enable this for all the said platforms.

Kenneth Rohde Christiansen

Comment 8 2010-01-31 07:10:40 PST

Comment on attachment 47414 [details] Enable the #define for Maemo 5, Qt Embedded and Symbian Let's do it then!

WebKit Commit Bot

Comment 9 2010-01-31 07:42:41 PST

Comment on attachment 47414 [details] Enable the #define for Maemo 5, Qt Embedded and Symbian Clearing flags on attachment: 47414 Committed r54109: <http://trac.webkit.org/changeset/54109>

WebKit Commit Bot

Comment 10 2010-01-31 07:42:48 PST

All reviewed patches have been landed. Closing bug.

Ismail Donmez

Comment 11 2010-01-31 08:33:14 PST

Not enabled on WinCE on purpose or just missed?

Kenneth Rohde Christiansen

Comment 12 2010-01-31 16:04:53 PST

Just missed I'm quite sure, feel free to provide a patch :-)

Ismail Donmez

Comment 13 2010-01-31 17:45:18 PST

The fix is one liner, if WinCE is supposed to be supported I'll send a patch.

Benjamin Poulain

Comment 14 2010-02-01 00:13:26 PST

Created attachment 47816 [details] Enable it for Windows CE (In reply to comment #12) > Just missed I'm quite sure, feel free to provide a patch :-) Sorry, I forgot Qt supports so many platforms :)

Ismail Donmez

Comment 15 2010-02-01 00:14:05 PST

Thanks!

Simon Hausmann

Comment 16 2010-03-22 04:45:39 PDT

Cherry-picked into qtwebkit-4.6 with commit d70761926b1215c30158a7c50809e98b5dc8170c

Note You need to log in before you can comment on or make changes to this bug.