Bug 34168

Summary:

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit Qt

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ariya.hidayat, benjamin, commit-queue, hausmann, ismail, kenneth, skyul

Priority:

Keywords:

Performance, Qt

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

34208

Attachments:

Description	Flags
Enable the #define for Maemo 5, Qt Embedded and Symbian	none
Enable it for Windows CE	kenneth: review+, kenneth: commit-queue+

Description Benjamin Poulain 2010-01-26 08:43:10 PST

https://bugs.webkit.org/show_bug.cgi?id=33408 introduces FAST_MOBILE_SCROLLING to disabled fixed background on embedded.
Qt Webkit could define that as well for its embedded platforms.

Comment 1 Benjamin Poulain 2010-01-26 08:46:18 PST

Created attachment 47414 [details]
Enable the #define for Maemo 5, Qt Embedded and Symbian

Comment 2 Kenneth Rohde Christiansen 2010-01-26 08:51:00 PST

We have to define if this is really what we want, as it changes the behaviour. Current iPhone and Android doesn't do anything like this, so this might be problematic.

Comment 3 Benjamin Poulain 2010-01-26 11:09:59 PST

(In reply to comment #2)
> We have to define if this is really what we want, as it changes the behaviour.
> Current iPhone and Android doesn't do anything like this, so this might be
> problematic.

I might be wrong but I had the impression they were using a virtual viewport of the size of the content. This would essentially give the same results.

Do you have one of those devices to check?

Comment 4 Eric Seidel (no email) 2010-01-26 14:00:09 PST

Comment on attachment 47414 [details]
Enable the #define for Maemo 5, Qt Embedded and Symbian

OK, i trust you.

Comment 5 Eric Seidel (no email) 2010-01-26 14:00:49 PST

Comment on attachment 47414 [details]
Enable the #define for Maemo 5, Qt Embedded and Symbian

Hmm... I'll leave a qter to decide if this should actually be committed.

Comment 6 Benjamin Poulain 2010-01-27 01:45:30 PST

(In reply to comment #2)
> We have to define if this is really what we want, as it changes the behaviour.
> Current iPhone and Android doesn't do anything like this, so this might be
> problematic.

Andreas just tested that on an iPhone, this gives the same behavior.
The way to achieve that is different as I mentioned.

Comment 7 Ariya Hidayat 2010-01-31 06:59:16 PST

I agree. We should certainly enable this for all the said platforms.

Comment 8 Kenneth Rohde Christiansen 2010-01-31 07:10:40 PST

Comment on attachment 47414 [details]
Enable the #define for Maemo 5, Qt Embedded and Symbian

Let's do it then!

Comment 9 WebKit Commit Bot 2010-01-31 07:42:41 PST

Comment on attachment 47414 [details]
Enable the #define for Maemo 5, Qt Embedded and Symbian

Clearing flags on attachment: 47414

Committed r54109: <http://trac.webkit.org/changeset/54109>

Comment 10 WebKit Commit Bot 2010-01-31 07:42:48 PST

All reviewed patches have been landed.  Closing bug.

Comment 11 Ismail Donmez 2010-01-31 08:33:14 PST

Not enabled on WinCE on purpose or just missed?

Comment 12 Kenneth Rohde Christiansen 2010-01-31 16:04:53 PST

Just missed I'm quite sure, feel free to provide a patch :-)

Comment 13 Ismail Donmez 2010-01-31 17:45:18 PST

The fix is one liner, if WinCE is supposed to be supported I'll send a patch.

Comment 14 Benjamin Poulain 2010-02-01 00:13:26 PST

Created attachment 47816 [details]
Enable it for Windows CE

(In reply to comment #12)
> Just missed I'm quite sure, feel free to provide a patch :-)

Sorry, I forgot Qt supports so many platforms :)

Comment 15 Ismail Donmez 2010-02-01 00:14:05 PST

Thanks!

Comment 16 Simon Hausmann 2010-03-22 04:45:39 PDT

Cherry-picked into qtwebkit-4.6 with commit d70761926b1215c30158a7c50809e98b5dc8170c