| Summary: | Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric, mitz | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2010-01-24 19:24:33 PST
Created attachment 47306 [details]
Reduction
Created attachment 50078 [details]
Another testcase
Here's another testcase, which doesn't involve any 0x0 layers.
In the second testcase, the assertion is firing because there's a layer whose parent is composited, but that parent is not a stacking context, so the layer is not rendered by that parent. Thus, the parent computes its own clip rects relative to itself, but when that layer asks for its parent's clip rects, it's asking with the root layer as the clip rects root. Ah, <object> tag is triggering this because of the call to FrameView::windowClipRectForLayer() from -[WebBaseNetscapePluginView _windowClipRect] Created attachment 50119 [details]
Patch
Comment on attachment 50119 [details] Patch > + Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com > + https://bugs.webkit.org/show_bug.cgi?id=34065 Please add the Radar link. You may remove one instance of “assertion”. Created attachment 50121 [details]
Patch
Comment on attachment 50119 [details]
Patch
Stupid webkit-patch
Comment on attachment 50119 [details] Patch http://trac.webkit.org/changeset/55597 Did this land? And what did webkit-patch do that you'd not like it to? I'm happy to fix any and all webkit-patch bugs if you file them. :) webkit-patch obsoleted an earlier, non-overlapping patch in the bug when attaching a second patch. Sometimes we do need to track > 1 patch per bug. (In reply to comment #12) > webkit-patch obsoleted an earlier, non-overlapping patch in the bug when > attaching a second patch. > > Sometimes we do need to track > 1 patch per bug. Agreed. We decided to optimize for the common case. You can always pass --no-obsolete to any command which does obsoleting and it will stop. :) |