Bug 34051

Summary: [Qt] Fix compilation on Maemo5
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch laszlo.gombos: review+

Simon Hausmann
Reported 2010-01-24 02:07:16 PST
[Qt] Fix compilation of QtLauncher on Maemo5
Attachments
Patch (1.15 KB, patch)
2010-01-24 02:08 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2010-01-24 03:20 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (1.05 KB, patch)
2010-01-25 04:51 PST, Simon Hausmann 		laszlo.gombos: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-01-24 02:08:27 PST
Created attachment 47290 [details] Patch
Simon Hausmann
Comment 2 2010-01-24 03:20:42 PST
Created attachment 47294 [details] Patch
Laszlo Gombos
Comment 3 2010-01-24 19:58:33 PST
Symbian port of Qt does not come with uitools either. I think Maemo5 and Symbian should have the same solution for this. Maybe a simple line WebKit.pri would do ? @@ -77,6 +77,8 @@ QMAKE_CXXFLAGS.ARMCC += $$RVCT_COMMON_CXXFLAGS } +maemo5: DEFINES *= QT_NO_UITOOLS + contains(DEFINES, QT_NO_UITOOLS): CONFIG -= uitools A while back I proposed to create a mobile profile for QtWebKit to combine Maemo5, Symbian and perhaps WinCE and embedded. Maybe it would be a good time to introduce that ?
Simon Hausmann
Comment 4 2010-01-25 01:35:35 PST
(In reply to comment #3) > Symbian port of Qt does not come with uitools either. I think Maemo5 and > Symbian should have the same solution for this. Maybe a simple line WebKit.pri > would do ? > > @@ -77,6 +77,8 @@ > QMAKE_CXXFLAGS.ARMCC += $$RVCT_COMMON_CXXFLAGS > } > > +maemo5: DEFINES *= QT_NO_UITOOLS > + > contains(DEFINES, QT_NO_UITOOLS): CONFIG -= uitools Ohh, you're right, that's better. I didn't see that the fix for Symbian was done there, I thought uitools was built there. Ok, I'll fix it :) > > A while back I proposed to create a mobile profile for QtWebKit to combine > Maemo5, Symbian and perhaps WinCE and embedded. Maybe it would be a good time > to introduce that ? Yeah, in the long run we need that. I'd like to see that come out of Qt.
Simon Hausmann
Comment 5 2010-01-25 01:36:01 PST
Comment on attachment 47294 [details] Patch Clearning review. Alternate fix coming up
Simon Hausmann
Comment 6 2010-01-25 04:51:55 PST
Created attachment 47337 [details] Patch
Laszlo Gombos
Comment 7 2010-01-25 04:53:34 PST
Comment on attachment 47337 [details] Patch lgtm.
Eric Seidel (no email)
Comment 8 2010-02-01 16:13:02 PST
Attachment 47337 [details] was posted by a committer and has review+, assigning to Simon Hausmann for commit.
Simon Hausmann
Comment 9 2010-02-12 06:29:40 PST
Landed in r53800
Note You need to log in before you can comment on or make changes to this bug.