Bug 34047

Summary: "endedPlayback" logic doesn't match spec
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Severity: Normal CC: eric
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Proposed patch simon.fraser: review+

Description Eric Carlson 2010-01-23 23:05:19 PST
Section, "Playing the media resource" says:

"A media element is said to have ended playback when the element's readyState attribute is HAVE_METADATA or greater, and either the current playback position is the end of the media resource and the direction of playback is forwards and the media element does not have a loop attribute specified, or the current playback position is the earliest possible position and the direction of playback is backwards."

but WebKit's HTMLMediaElement doesn't consider the direction of playback at all.
Comment 1 Eric Carlson 2010-01-23 23:07:00 PST
Comment 2 Eric Carlson 2010-01-23 23:14:14 PST
Created attachment 47287 [details]
Proposed patch
Comment 3 Simon Fraser (smfr) 2010-01-24 08:35:14 PST
Comment on attachment 47287 [details]
Proposed patch

r=me but I wonder if the !loop() check should be done for backwards playback. Is reverse looping supposed to work?
Comment 4 Eric Carlson 2010-01-24 10:04:29 PST
Reverse looping isn't supported:
The loop attribute is a boolean attribute that, if specified, indicates that the media element is to seek back to the start of the media resource upon reaching the end.

When the current playback position reaches the earliest possible position of the media resource when the direction of playback is backwards, then the user agent must follow these steps:

1. Stop playback.

2. The user agent must queue a task to fire a simple event named timeupdate at the element.
Comment 5 Eric Carlson 2010-01-24 10:05:03 PST
Thanks for the review!
Comment 7 Eric Seidel (no email) 2010-01-24 14:22:44 PST
Looks like it broke Tiger in the same way:

(Just trying to clean up the bots after the commit-bot broke windows last night.)
Comment 8 Eric Carlson 2010-01-24 14:56:21 PST
http://trac.webkit.org/changeset/53786 should fix both, I made the test only log the first 'timeupdate' event.
Comment 9 Eric Seidel (no email) 2010-01-24 17:14:05 PST
Thanks!  Should this bug stay open for further work, or should we close it?