|Summary:||Assertion failure in KURL::setProtocol when running DOM Fuzzer|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||Platform||Assignee:||Alexey Proskuryakov <ap>|
|Severity:||Normal||CC:||ajwong, darin, dglazkov, levin, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Alexey Proskuryakov 2010-01-22 10:41:40 PST
Patch forthcoming. This is harmless in release builds.
Comment 1 Alexey Proskuryakov 2010-01-22 10:51:31 PST
Created attachment 47212 [details] proposed fix We have similar issues with other KURL setters, but my primary goal here is to prevent the assertion failure when running DOM Fuzzer. Also, establishing correct behavior for each setter is not trivial, and is well worth a separate patch for each.
Comment 2 WebKit Review Bot 2010-01-22 11:05:46 PST
Attachment 47212 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/206004
Comment 3 Darin Adler 2010-01-22 11:40:33 PST
Google has their own KURL -- I wish that were not so -- so I guess someone has to fix that.
Comment 4 Alexey Proskuryakov 2010-01-22 11:52:15 PST
I can change KURLGoogle:setProtocol() to always return true, but Chromium would still have regressions in tests. Do we have the same "feel free to break it" agreement about KURLGoogle that we have about v8 bindings?
Comment 5 David Levin 2010-01-22 11:55:03 PST
(In reply to comment #4) > I can change KURLGoogle:setProtocol() to always return true, but Chromium would > still have regressions in tests. Do we have the same "feel free to break it" > agreement about KURLGoogle that we have about v8 bindings? I think so :( I've cc'ed Albert who gets to handle this today.
Comment 6 Darin Adler 2010-01-22 12:17:09 PST
Comment 7 Alexey Proskuryakov 2010-01-22 13:01:22 PST
Committed <http://trac.webkit.org/changeset/53712>. I made KURLGoogle.cpp changes that will hopefully prevent build failure, but not test failures.
Comment 8 Alexey Proskuryakov 2010-01-22 14:12:41 PST
Sorry, forgot to do anything about the UTF-8 BOM. But this isn't the first script test that includes one.