Bug 33994

Summary: Improve portability of listbox-selection-2.html
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 24161    
Description Flags
Proposed patch
Proposed patch (rev.2) none

Description Kent Tamura 2010-01-22 02:00:53 PST
LayoutTest/fast/forms/listbox-selection-2.html uses Mac-specific metrics.
Comment 1 Kent Tamura 2010-01-22 02:04:22 PST
Created attachment 47181 [details]
Proposed patch
Comment 2 Kent Tamura 2010-01-22 02:05:54 PST
(In reply to comment #1)
> Created an attachment (id=47181) [details]
> Proposed patch

I confirmed the patched test worked on Mac and Chromium/Windows.
Comment 3 Maciej Stachowiak 2010-01-22 02:21:36 PST
Comment on attachment 47181 [details]
Proposed patch

Comment 4 WebKit Commit Bot 2010-01-22 03:32:47 PST
Comment on attachment 47181 [details]
Proposed patch

Rejecting patch 47181 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12032 test cases.
fast/forms/listbox-selection-2.html -> failed

Exiting early after 1 failures. 6671 tests run.
105.53s total testing time

6670 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
2 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/203743
Comment 5 Kent Tamura 2010-01-22 05:09:56 PST
I'll investigate this on Monday.
Comment 6 Kent Tamura 2010-01-24 17:53:51 PST
Created attachment 47302 [details]
Proposed patch (rev.2)
Comment 7 WebKit Commit Bot 2010-01-24 19:26:31 PST
Comment on attachment 47302 [details]
Proposed patch (rev.2)

Clearing flags on attachment: 47302

Committed r53788: <http://trac.webkit.org/changeset/53788>
Comment 8 WebKit Commit Bot 2010-01-24 19:26:37 PST
All reviewed patches have been landed.  Closing bug.