Bug 33994

Summary:

Improve portability of listbox-selection-2.html

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

24161

Attachments:

Description	Flags
Proposed patch	none
Proposed patch (rev.2)	none

Kent Tamura

Reported 2010-01-22 02:00:53 PST

LayoutTest/fast/forms/listbox-selection-2.html uses Mac-specific metrics.

Attachments
Proposed patch (55.93 KB, patch) 2010-01-22 02:04 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Proposed patch (rev.2) (48.41 KB, patch) 2010-01-24 17:53 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2010-01-22 02:04:22 PST

Created attachment 47181 [details] Proposed patch

Kent Tamura

Comment 2 2010-01-22 02:05:54 PST

(In reply to comment #1) > Created an attachment (id=47181) [details] > Proposed patch I confirmed the patched test worked on Mac and Chromium/Windows.

Maciej Stachowiak

Comment 3 2010-01-22 02:21:36 PST

Comment on attachment 47181 [details] Proposed patch r=me

WebKit Commit Bot

Comment 4 2010-01-22 03:32:47 PST

Comment on attachment 47181 [details] Proposed patch Rejecting patch 47181 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12032 test cases. fast/forms/listbox-selection-2.html -> failed Exiting early after 1 failures. 6671 tests run. 105.53s total testing time 6670 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 2 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/203743

Kent Tamura

Comment 5 2010-01-22 05:09:56 PST

I'll investigate this on Monday.

Kent Tamura

Comment 6 2010-01-24 17:53:51 PST

Created attachment 47302 [details] Proposed patch (rev.2)

WebKit Commit Bot

Comment 7 2010-01-24 19:26:31 PST

Comment on attachment 47302 [details] Proposed patch (rev.2) Clearing flags on attachment: 47302 Committed r53788: <http://trac.webkit.org/changeset/53788>

WebKit Commit Bot

Comment 8 2010-01-24 19:26:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.