Bug 33972

Summary: Assertion failure in FrameLoader::checkLoadComplete()
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Bug Depends on:    
Bug Blocks: 29692    
Attachments:
Description Flags
proposed fix darin: review+

Alexey Proskuryakov
Reported 2010-01-21 14:39:37 PST
I'm frequently seeing assertion failure in FrameLoader::checkLoadComplete(): ASSERT(m_client->hasWebView()); I couldn't make a test case, but the sequence of events if roughly as follows: - a subframe is detached (FrameLoader::detachFromParent is called); - this results in a Frame::pageDestroyed() call (which is a lie, as Page is not destroyed); - after a while, FrameLoader's checkTimer fires; - since Frame::m_page is null now, m_client->hasWebView() returns false. This doesn't always happen, because usually, Frame is destructed before checkTimer has a chance to fire, canceling the timer. But Frame destruction is not totally deterministic, and I see Frame::m_lifeSupportTimer timer sometimes keep it alive long enough for FrameLoader::checkTimer to fire.
Attachments
proposed fix (1.28 KB, patch)
2010-01-21 14:47 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-01-21 14:40:02 PST
<rdar://problem/7545095>
Alexey Proskuryakov
Comment 2 2010-01-21 14:47:57 PST
Created attachment 47147 [details] proposed fix
Alexey Proskuryakov
Comment 3 2010-01-21 15:21:24 PST
Committed <http://trac.webkit.org/changeset/53655>.
Note You need to log in before you can comment on or make changes to this bug.