Summary: | [GTK] Fails /LayoutTests/fast/css/button-height.html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, mrobinson, xan.lopez, zecke | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Daniel Bates
2010-01-20 19:09:31 PST
Rolling out change set 53591 <http://trac.webkit.org/changeset/53591> since it caused a regression of the test /fast/replaced/table-percent-height.html on the Qt bot. There appears to be an issue on GTK with regards to the rendering of button heights, but since I am rolling out r53591 (which includes the test button-height.html) it invalidates the reason this bug was filed. We should probably look into the GTK button rendering code/file a separate bug. Re-committed patch that includes test button-height.html in change set 53897 <http://trac.webkit.org/changeset/53897>. Created attachment 70292 [details]
Patch for this issue
Comment on attachment 70292 [details]
Patch for this issue
This looks sane to me.
I assume at some place the height of the button is computed based on the height of the button text.
Committed r69436: <http://trac.webkit.org/changeset/69436> |