Bug 33926

Summary:

WebDownloadCFNet doesn't remember the overwrite setting from setDownload

Product:

WebKit

Reporter:

Ryan Grimm <grimm>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

adachan, aroben, beidson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Sample code to help reproducing the bug	none

Ryan Grimm

Reported 2010-01-20 16:49:23 PST

Created attachment 47078 [details] Sample code to help reproducing the bug If you create a download delegate that sets the download->setDestination allowOverwrite argument to true and the file exists, the file will not actually be overridden. This happens because the MoveFileEx call in the didFinish method of WebDownloadCFNet.cpp always passes 0 as the third argument when it should pass MOVEFILE_REPLACE_EXISTING when allowOverwrite was set to true. I'm including some stripped down code that should be able to reproduce the issue. Just split the file out into .cpp and .h files and call the ManualDownload() function passing in any url.

Attachments
Sample code to help reproducing the bug (4.53 KB, text/plain) 2010-01-20 16:49 PST, Ryan Grimm	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Note You need to log in before you can comment on or make changes to this bug.