Bug 33921

Summary:

[chromium] theme selection colors to match gtk theme

Product:

WebKit

Reporter:

Elliot Glaysher <erg>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, evan, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Elliot Glaysher 2010-01-20 15:04:03 PST

[chromium] theme selection colors to match gtk theme

Comment 1 Elliot Glaysher 2010-01-20 15:09:52 PST

Created attachment 47067 [details]
Patch

Comment 2 WebKit Review Bot 2010-01-20 15:13:16 PST

Attachment 47067 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Review Bot 2010-01-20 15:13:21 PST

Unexpected failure while processing patch!  Please file a bug against webkit-patch.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'check-style', '--force-clean', '--non-interactive', '--parent-command=style-queue', '47067']" exit_code: 1
Last 500 characters of output:
_error.message
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Adding comment to bug 33921
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5

Comment 4 Evan Martin 2010-01-20 15:16:51 PST

Comment on attachment 47067 [details]
Patch

r- for not passing style bot

Comment 5 Elliot Glaysher 2010-01-20 15:23:34 PST

Created attachment 47070 [details]
Patch

Comment 6 David Levin 2010-01-20 17:34:56 PST

This seems reasonable, but I would appreciate comments from Evan before doing an r+ since he is more familiar with the platform (and he reviewed the chromium side).

Comment 7 Evan Martin 2010-01-20 17:39:54 PST

LGTM

Comment 8 Elliot Glaysher 2010-01-22 11:09:24 PST

Could someone please set commit-queue+ on this patch? Landing this patch by itself won't break chromium.

Comment 9 WebKit Commit Bot 2010-01-22 21:27:46 PST

Comment on attachment 47070 [details]
Patch

Clearing flags on attachment: 47070

Committed r53759: <http://trac.webkit.org/changeset/53759>

Comment 10 WebKit Commit Bot 2010-01-22 21:27:52 PST

All reviewed patches have been landed.  Closing bug.