|Summary:||FastAllocBase is probably making many of our objects a bit bigger|
|Product:||WebKit||Reporter:||Zoltan Horvath <zoltan>|
|Component:||Web Template Framework||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||ap, darin, skyul|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Zoltan Horvath 2010-01-20 05:45:48 PST
Adding FastAllocBase as base class for objects has been making them all larger this is inflating WebKit’s memory use. I'm going to collect the list of classes and try to measure the overhead.
Comment 1 Zoltan Horvath 2010-02-11 06:14:00 PST
Created attachment 48558 [details] List of classes which first member is RefPtr and inherited from FastAllocBase This list contains almost all classes (142) which are inherited from FastAllocBase and their first member is a RefPtr.
Comment 2 Zoltan Horvath 2010-02-11 06:53:36 PST
Created attachment 48560 [details] List of classes which are instantiated by new and inherited from FastAllocBase I did another analysis . This txt contains the list of classes - 956 pieces - which are instantiated by new and inherited from FastAllocBase somehow.
Comment 4 Zoltan Horvath 2010-03-31 01:02:41 PDT
Comment 5 Darin Adler 2010-03-31 10:37:05 PDT
(In reply to comment #4) > 2. Make FastAllocBase a class template and inherit from FastAllocBase<X>, so > padding won't be added. Lets do that.
Comment 6 Zoltan Horvath 2010-04-07 03:43:46 PDT
(In reply to comment #5) > (In reply to comment #4) > > 2. Make FastAllocBase a class template and inherit from FastAllocBase<X>, so > > padding won't be added. > > Lets do that. I tested this solution on a simple instance and unfortunately it didn't work. Padding was added in template case as well.