Bug 3387

Summary: Redundant keydown, keypress, keyup events sent for arrow keys
Product: WebKit Reporter: Nat Irons <natty>
Component: DOMAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aapo-bugzilla, ap, beau, bugzilla+opendarwin, ccallender, hyatt, ian, mrowe, richard, zapperlott
Priority: P2 Keywords: InRadar
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.quirksmode.org/js/events/document.html
Attachments:
Description Flags
proposed fix timothy: review+

Nat Irons
Reported 2005-06-09 09:46:35 PDT
Safari 1.3, 2.0 and the 2005-05-09 webkit CVS all send pairs of the required key events for the arrow keys. The attached test page records the Safari event sequence for a single tap as "keydown, keypress, keydown, keypress, keyup, keyup". I happen to have a 10.2.8 machine handy with Safari 1.0.3, which does not exhibit this behavior. Nor do Firefox 1.0.4, IE/Mac 5.2.2, or IE/Win 6. Safari sends single "keydown, keypress, keyup" events for keys other than arrows. Safari 2.0 and the CVS version were tested on 10.4.1.
Attachments
proposed fix (7.70 KB, patch)
2006-11-11 12:07 PST, Alexey Proskuryakov 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-03-26 06:25:54 PST
*** Bug 7876 has been marked as a duplicate of this bug. ***
mitz
Comment 2 2006-05-05 07:31:40 PDT
I wonder if bug 8136 (a regression) is caused by redundant keyboard events.
Alexey Proskuryakov
Comment 3 2006-06-24 15:33:21 PDT
Reassigning to webkit-unassigned, to make sure more people see this.
David Kilzer (:ddkilzer)
Comment 4 2006-06-30 11:40:55 PDT
Hyatt: I had a crazy idea...could this be the cause of some of the performance problems with arrowing down to scroll a page?
Alexey Proskuryakov
Comment 5 2006-08-16 21:47:20 PDT
*** Bug 10450 has been marked as a duplicate of this bug. ***
Richard Standbrook
Comment 6 2006-09-21 01:39:39 PDT
(In reply to comment #4) > Hyatt: I had a crazy idea...could this be the cause of some of the performance > problems with arrowing down to scroll a page? > I have seen the same problem with the function keys, escape key, home key and the page up / page down keys. not just the arrow keys.
Dave Hyatt
Comment 7 2006-09-21 16:28:32 PDT
I wasn't aware there were perf problems when arrowing... do you have an example?
Richard Standbrook
Comment 8 2006-09-22 01:44:48 PDT
(In reply to comment #7) > I wasn't aware there were perf problems when arrowing... do you have an > example? > see http://trac.mochikit.com/ticket/182 I'm using OS X 10.4.7 and Safari 2.0.4 on PowerPC (also behaves the same on my Intel with, I think, the same versions) I have also tried webkit nightly build from 21/09/06
Alexey Proskuryakov
Comment 9 2006-11-11 09:32:03 PST
To work around this problem, one can cancel default processing of the event by returning false from its handler.
Alexey Proskuryakov
Comment 10 2006-11-11 12:07:19 PST
Created attachment 11487 [details] proposed fix
Timothy Hatcher
Comment 11 2006-11-13 17:23:19 PST
<rdar://problem/4125399>
Alexey Proskuryakov
Comment 12 2006-11-14 10:21:28 PST
Committed revision 17760.
Note You need to log in before you can comment on or make changes to this bug.