Summary: | Occasional crash when interacting with page with reflected WebGL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-01-19 13:42:19 PST
Created attachment 46949 [details]
Patch
Comment on attachment 46949 [details] Patch > if (layer->backing()) { > + // If we're removing backing on a reflection, clear the source GraphicsLayer's pointer to > + // its replica GraphicsLayer. In practise this should never happen So can we add an assertion? > + if (layer->isReflection()) { > + RenderLayer* sourceLayer = toRenderBoxModelObject(layer->renderer()->parent())->layer(); > + if (RenderLayerBacking* backing = sourceLayer->backing()) > + backing->graphicsLayer()->setReplicatedByLayer(0); And also assert right before here that the graphicsLayer currently thinks that it’s replicated by our layer? r=me |