Bug 33814

Summary:

WebKitTools/Scripts/check-webkit-style gives false positives in single-line functions.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bashi, commit-queue, hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Hamaji-san, Thank you for your quick review. I put semicolons after brackets.	none

Description Gavin Barraclough 2010-01-18 15:35:51 PST

Some examples in:

https://bugs.webkit.org/show_bug.cgi?id=33731

We allow single-line functions declared in the header (within the class definition) for fairly trivial accessors.  Not a big issue, but would be awesome if the script was aware of these cases.

Comment 1 Kenichi Ishibashi 2010-07-28 08:57:59 PDT

Created attachment 62831 [details]
Patch

Comment 2 Shinichiro Hamaji 2010-07-28 12:30:57 PDT

Comment on attachment 62831 [details]
Patch

Looks great. I'll make the following changes when I'll land this patch.

WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2600
 +              '}\n',
I'd put a semicolon so this code is valid as C++.

WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2608
 +              '}\n',
ditto

Comment 3 Gavin Barraclough 2010-07-28 16:23:55 PDT

Yay! this bug has been annoying me so much I've been considering learning python!  This is constantly biting me, I'm so happy to see this fixed, thank you!

Comment 4 Kenichi Ishibashi 2010-07-28 17:43:20 PDT

Created attachment 62901 [details]
Hamaji-san, Thank you for your quick review. I put semicolons after brackets.

Comment 5 Shinichiro Hamaji 2010-07-28 18:05:22 PDT

Comment on attachment 62901 [details]
Hamaji-san, Thank you for your quick review. I put semicolons after brackets.

Thanks for your update!

Comment 6 WebKit Commit Bot 2010-07-28 20:36:52 PDT

Comment on attachment 62901 [details]
Hamaji-san, Thank you for your quick review. I put semicolons after brackets.

Clearing flags on attachment: 62901

Committed r64263: <http://trac.webkit.org/changeset/64263>

Comment 7 WebKit Commit Bot 2010-07-28 20:36:57 PDT

All reviewed patches have been landed.  Closing bug.