Frame::matchLabelsAgainstElement should take id attribute into account (as well as name)

• Component: Forms
• Status: RESOLVED FIXED

[John Sullivan]

Frame::matchLabelsAgainstElement() is used at least by Safari for trying to guess what kind of data is expected by a form field -- e.g., phone number, street address, zip code, etc.

Currently this function only checks the name attribute of the given element. It would do a better job of guessing if it also checked the id attribute when the name attribute check fails.

[John Sullivan]

Created attachment 46725 [details]
Test case that was reduced from http://www.autotrader.com

[John Sullivan]

This bug is in radar as 7538330.

[John Sullivan]

Created attachment 46726 [details]
Patch for platform-agnostic and Mac versions of the relevant code.

[WebKit Review Bot]

Attachment 46726 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/Frame.cpp:542:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1

[John Sullivan]

Created attachment 46728 [details]
Revised patch that fixes the doubled semicolon.

[Darin Adler]

Comment on attachment 46728 [details]
Revised patch that fixes the doubled semicolon.

I'm not so fond with the name "mutable" in the local variable names here. It's also too bad we have no way to write regression tests for this function.

r=me despite that tho

[John Sullivan]

Checked in as r53367.