Bug 33728

Summary: svg/custom/marker-changes.svg is flaky
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Description Ojan Vafai 2010-01-15 11:48:47 PST
svg/custom/marker-changes.svg is flaky
Comment 1 Ojan Vafai 2010-01-15 11:49:47 PST
Created attachment 46694 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-01-15 11:55:12 PST
Comment on attachment 46694 [details]
Patch

But your'e not removing the setTimeout?  You're just moving it... no?  I'm confused why this test needs one at all.
Comment 3 Ojan Vafai 2010-01-15 12:03:37 PST
Created attachment 46695 [details]
Patch
Comment 4 Ojan Vafai 2010-01-15 12:04:32 PST
(In reply to comment #2)
> (From update of attachment 46694 [details])
> But your'e not removing the setTimeout?  You're just moving it... no?  I'm
> confused why this test needs one at all.

Duh. I was just focused on the race. Removed the setTimeout for real this time and no longer needing to waitUntilDone.
Comment 5 Eric Seidel (no email) 2010-01-15 12:06:30 PST
Comment on attachment 46695 [details]
Patch

Assuming it still passes, LGTM.
Comment 6 Ojan Vafai 2010-01-15 12:20:23 PST
Committed r53337: <http://trac.webkit.org/changeset/53337>