Bug 33710

Summary:

WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, darin, mrowe, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

33672

Attachments:

Description	Flags
Patch 1 for Bug 33710	mrowe: review-
Patch 2 for Bug 33710	none
Patch 3 for Bug 33710	dimich: review+, dimich: commit-queue-

Steve Block

Reported 2010-01-15 03:04:14 PST

WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js. When referring to WebKit’s built-in JavaScript engine, the precedent is to use js, rather than jsc for the directory name. See Bug 33672.

Attachments
Patch 1 for Bug 33710 (37.76 KB, patch) 2010-01-15 03:10 PST, Steve Block	mrowe: review-	Details Formatted Diff Diff
Patch 2 for Bug 33710 (34.17 KB, patch) 2010-01-15 03:53 PST, Steve Block	no flags	Details Formatted Diff Diff
Patch 3 for Bug 33710 (35.25 KB, patch) 2010-01-15 08:12 PST, Steve Block	dimich: review+ dimich: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-01-15 03:10:46 PST

Created attachment 46664 [details] Patch 1 for Bug 33710 Renames WebCore/bridge/jni/jsc to WebCore/bridge/jni/js. Also renames jni_utility_private.[cpp|h] to JniUtilityPrivate.[cpp|h].

Mark Rowe (bdash)

Comment 2 2010-01-15 03:23:42 PST

Comment on attachment 46664 [details] Patch 1 for Bug 33710 JNI is an acronym and therefore should be expressed in all caps rather than in title case. Is there some reason that you’re renaming only two of the 13 files that are named in this manner? It would be more logical to me if you did the directory rename in one step, and then renamed all of the misnamed files at once in a follow-up change.

Steve Block

Comment 3 2010-01-15 03:52:13 PST

(In reply to comment #2) > (From update of attachment 46664 [details]) > JNI is an acronym and therefore should be expressed in all caps rather than in > title case. > > Is there some reason that you’re renaming only two of the 13 files that are > named in this manner? It would be more logical to me if you did the directory > rename in one step, and then renamed all of the misnamed files at once in a > follow-up change. OK, I've opened Bug 33712 to rename all of these files and will update the patch to just rename the directory.

Steve Block

Comment 4 2010-01-15 03:53:40 PST

Created attachment 46670 [details] Patch 2 for Bug 33710 Renames WebCore/bridge/jni/jsc to WebCore/bridge/jni/js

Steve Block

Comment 5 2010-01-15 08:12:44 PST

Created attachment 46682 [details] Patch 3 for Bug 33710 Now with ChangeLog

Dmitry Titov

Comment 6 2010-01-15 14:54:51 PST

Comment on attachment 46682 [details] Patch 3 for Bug 33710 r=me, cq-, I assume you want to manually land this one.

Steve Block

Comment 7 2010-01-18 02:41:41 PST

jsc is the correct name for this directory See https://bugs.webkit.org/show_bug.cgi?id=33672#c7 Marking as won't fix

Note You need to log in before you can comment on or make changes to this bug.