Bug 33710

Summary: WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, darin, mrowe, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 33672    
Attachments:
Description Flags
Patch 1 for Bug 33710
mrowe: review-
Patch 2 for Bug 33710
none
Patch 3 for Bug 33710 dimich: review+, dimich: commit-queue-

Description Steve Block 2010-01-15 03:04:14 PST
WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js. When referring to WebKit’s built-in JavaScript engine, the precedent is to use js, rather than jsc for the directory name. See Bug 33672.
Comment 1 Steve Block 2010-01-15 03:10:46 PST
Created attachment 46664 [details]
Patch 1 for Bug 33710

Renames WebCore/bridge/jni/jsc to WebCore/bridge/jni/js. Also renames jni_utility_private.[cpp|h] to JniUtilityPrivate.[cpp|h].
Comment 2 Mark Rowe (bdash) 2010-01-15 03:23:42 PST
Comment on attachment 46664 [details]
Patch 1 for Bug 33710

JNI is an acronym and therefore should be expressed in all caps rather than in title case.

Is there some reason that you’re renaming only two of the 13 files that are named in this manner?  It would be more logical to me if you did the directory rename in one step, and then renamed all of the misnamed files at once in a follow-up change.
Comment 3 Steve Block 2010-01-15 03:52:13 PST
(In reply to comment #2)
> (From update of attachment 46664 [details])
> JNI is an acronym and therefore should be expressed in all caps rather than in
> title case.
> 
> Is there some reason that you’re renaming only two of the 13 files that are
> named in this manner?  It would be more logical to me if you did the directory
> rename in one step, and then renamed all of the misnamed files at once in a
> follow-up change.

OK, I've opened Bug 33712 to rename all of these files and will update the patch to just rename the directory.
Comment 4 Steve Block 2010-01-15 03:53:40 PST
Created attachment 46670 [details]
Patch 2 for Bug 33710

Renames WebCore/bridge/jni/jsc to WebCore/bridge/jni/js
Comment 5 Steve Block 2010-01-15 08:12:44 PST
Created attachment 46682 [details]
Patch 3 for Bug 33710

Now with ChangeLog
Comment 6 Dmitry Titov 2010-01-15 14:54:51 PST
Comment on attachment 46682 [details]
Patch 3 for Bug 33710

r=me, cq-, I assume you want to manually land this one.
Comment 7 Steve Block 2010-01-18 02:41:41 PST
jsc is the correct name for this directory
See https://bugs.webkit.org/show_bug.cgi?id=33672#c7

Marking as won't fix