Summary: | Make naming & behaviour of UString[Impl] methods more consistent. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2010-01-14 18:22:48 PST
Created attachment 46632 [details]
The patch
Attachment 46632 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/StringPrototype.cpp:735: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
JavaScriptCore/runtime/StringPrototype.cpp:772: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
JavaScriptCore/runtime/UStringImpl.h:161: More than one command on the same line [whitespace/newline] [4]
Total errors found: 3
Attachment 46632 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/187794 Looks like this broke the Windows build: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/9727/steps/compile-webkit/logs/stdio At least the Debug build, or so http://build.webkit.org/console thinks. I think this is the error: WebCore_debug.lib(XMLHttpRequest.obj) : error LNK2019: unresolved external symbol "public: static class JSC::UString __cdecl JSC::UString::createNonCopying(wchar_t *,int)" (?createNonCopying@UString@JSC@@SA?AV12@PA_WH@Z) referenced in function "public: class JSC::UString __thiscall JSC::StringBuilder::release(void)" (?release@StringBuilder@JSC@@QAE?AVUString@2@XZ) Sadly we don't have a Windows EWS bot yet. I'm aware of this & can't see what is causing it – I think it might just be something stale on the bot, I'm going to email brian & ask him to give it a kick in the morning. cheers, G. |