Bug 33689 – WebSocket: Missing Request-URI, when no tralling slash in host

• Component: New Bugs
• Status: RESOLVED FIXED

If host provided to WebSocket constructor does'n have tralling slash, for example "ws://domain:port" or "ws://domain", WebSocket send GET request without Request-URI.

var ws = new WebSocket("ws://domain") 

Produces: 

GET HTTP/1.1
Upgrade: WebSocket
Connection: Upgrade
Host: localhost
Origin: http://localhost

[Fumitoshi Ukai]

Confirmed it on Safari nightly build.
(no problem with Chromium, though)

[Fumitoshi Ukai]

Created attachment 46648 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 46648 [details]
Patch

Code changes look good, but I think I'll ask to rework the test. It has absolutely no reason to be script-tests-based - it doesn't have even a single shouldBe anywhere! A bigger issue is that test output doesn't really mention pass/fail criteria, and that it relies on assertions that may be gone at the same time the bug is reintroduced.

A more reliable way to test this would be for the server to report invalid requests in some manner (possibly by setting a state that can be retrieved later, or maybe by intercepting these and forwarding to a specific handler whose response we could check).

[Fumitoshi Ukai]

Created attachment 46989 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 46989 [details]
Patch

> +    print STDERR "args: @args\n";

Did you mean to leave this in?

r=me

[Fumitoshi Ukai]

Committed r53592: <http://trac.webkit.org/changeset/53592>