Bug 33662

Summary: [GTK] RTP/RTSP streams playback support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, eric, gustavo, scherkus, slomo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
eric: review+
updated patch gustavo: review+

Philippe Normand
Reported 2010-01-14 02:18:53 PST
Our player should be able to play rtp/rtsp streams like this one: rtsp://a2047.v1411b.c1411.g.vq.akamaistream.net/5/2047/1411/2_h264_650/1a1a1ae454c430950065de4cbb2f94c226950c7ae655b61a48a91475e243acda3dac194879adde0f/wwdc_2006_2_650.mov I think the issue is that the pipeline changes state to NOPREROLL (because of the live source) and this code path doesn't seem well supported at the moment.
Attachments
proposed patch (6.47 KB, patch)
2010-02-17 03:48 PST, Philippe Normand 		eric: review+
DetailsFormatted DiffDiff
updated patch (4.19 KB, patch)
2010-02-18 06:48 PST, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-02-17 03:48:18 PST
Created attachment 48884 [details] proposed patch
Sebastian Dröge (slomo)
Comment 2 2010-02-17 08:35:59 PST
Looks good I guess
Eric Seidel (no email)
Comment 3 2010-02-17 15:19:10 PST
Comment on attachment 48884 [details] proposed patch OK. Looks sane.
Philippe Normand
Comment 4 2010-02-18 01:24:13 PST
The new test takes about 2.5 seconds to complete here. I don't think it is very good and Xan thinks the same. Gustavo, Eric, would you have an idea on how to improve the speed of the test?
Gustavo Noronha (kov)
Comment 5 2010-02-18 06:26:04 PST
Comment on attachment 48884 [details] proposed patch I'd turn this into a manual test, I think, given it needs to get to the interwebs, which I'd think is a no-no for layout tests. Also, the URI changing is quite likely, I'd guess?
Philippe Normand
Comment 6 2010-02-18 06:48:30 PST
Created attachment 49010 [details] updated patch With a manual test as suggested by Gustavo. The same URL is btw used in media/unsupported-rtsp.html which we skip.
Gustavo Noronha (kov)
Comment 7 2010-02-18 11:33:21 PST
Comment on attachment 49010 [details] updated patch Manual test looks good,thanks!
Philippe Normand
Comment 8 2010-02-19 00:31:23 PST
Landed in r55005. Thanks :)
Note You need to log in before you can comment on or make changes to this bug.