Bug 33646

Summary: Split websocket/tests/bad-sub-protocol.html
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mjs: review+

Fumitoshi Ukai
Reported 2010-01-13 19:16:09 PST
websocket/tests/bad-sub-protocol.html takes more than 1 sec. I can be made faster by executing subtests in parallel.
Attachments
Patch (13.79 KB, patch)
2010-01-21 01:16 PST, Fumitoshi Ukai 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2010-01-21 01:16:53 PST
Created attachment 47103 [details] Patch
Darin Adler
Comment 2 2010-01-21 10:46:26 PST
You say “in parallel”. I guess you must be talking about the special Chromium run_webkit_tests script, because the WebKit run-webkit-tests script does not run tests in parallel.
Darin Adler
Comment 3 2010-01-21 10:46:50 PST
I believe that for the standard run-webkit-tests, splitting this up will make the test even slower.
Fumitoshi Ukai
Comment 4 2010-01-21 21:59:49 PST
(In reply to comment #3) > I believe that for the standard run-webkit-tests, splitting this up will make > the test even slower. Yes, I thought the chromium run_webkit_tests scripts to make it run in parallel. So, is it better to have one test that takes longer time than to have several tests each of which finishes soon?
Darin Adler
Comment 5 2010-01-21 23:16:11 PST
It’s better to have tests running in parallel on all platforms!
Maciej Stachowiak
Comment 6 2010-01-22 02:23:18 PST
Comment on attachment 47103 [details] Patch r=me
Fumitoshi Ukai
Comment 7 2010-01-22 03:57:38 PST
Committed r53692: <http://trac.webkit.org/changeset/53692>
Fumitoshi Ukai
Comment 8 2010-01-22 05:22:04 PST
(In reply to comment #5) > It’s better to have tests running in parallel on all platforms! File a bug as https://bugs.webkit.org/show_bug.cgi?id=34000
Note You need to log in before you can comment on or make changes to this bug.