Bug 33634 – REGRESSION(53133): webkit-patch land dies if it can't find a bug id.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kenneth Russell]

"webkit-patch land" does not work for a new committer updating committers.py. Here is the Python traceback:

Traceback (most recent call last):
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkit-patch", line 108, in <module>
    WebKitPatch().main()
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main
    return command.check_arguments_and_execute(options, args, self)
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 54, in run
    bug_id = state.get("bug_id") or state["patch"].bug_id()
KeyError: 'patch'

[Eric Seidel (no email)]

It's failing to find "bug_id", it should never end up down the "patch" path here.

I suspect this happens when your ChangeLog is missing a bug id and is a recent regression from my Attachment refactoring: http://trac.webkit.org/changeset/53133

[Adam Barth]

Created attachment 46527 [details]
Patch

[Adam Barth]

Committed r53215: <http://trac.webkit.org/changeset/53215>

[Shinichiro Hamaji]

*** Bug 33578 has been marked as a duplicate of this bug. ***