Summary: | Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line rendering capabilities. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, joepeck, rik, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-01-13 12:31:07 PST
Created attachment 46487 [details]
[IMAGE] Looks like the original SourceFrame.
Created attachment 46489 [details]
[PATCH] Proposed change
This looks great. Could we use a non-monospace font for the line numbers, so the font cn be smaller? Right now the breakpoints look funny with monospace text. Comment on attachment 46489 [details] [PATCH] Proposed change > + selectionRange: function() > + { > + this._selection.range(); > + }, Should this return the range? Make it a getter too. > + // Paint currenlt line for editable mode only. Typo. > + if (this._lineNumberDecorator.mouseDown(location.line, e)) It seems odd to me that a decorator handles events. But it does make it easier. Can this be named handleMouseDown? > + this._cursorElement.style.display = "none"; Should be addStyleClass("hidden"). r+, but I suspect the selectionRange function has a bug. But it dosen't look to be called. Addressed comments (all but the addStyleClass one since it needs to be consistent with other places in class - will fix later). Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj A WebCore/inspector/front-end/SourceFrame2.js M WebCore/inspector/front-end/TextEditor.js M WebCore/inspector/front-end/TextEditorHighlighter.js M WebCore/inspector/front-end/TextEditorModel.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.html Committed r53205 |