Bug 33601

Summary: [BREWMP] Port systemBeep
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Port systemBeep to BREW
none
Port systemBeep to BREW
eric: review-
Port systemBeep to BREW none

Kwang Yul Seo
Reported 2010-01-13 08:32:46 PST
Implement systemBeep with IShell_Beep.
Attachments
Port systemBeep to BREW (2.63 KB, patch)
2010-01-13 08:35 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Port systemBeep to BREW (2.63 KB, patch)
2010-01-25 01:55 PST, Kwang Yul Seo 		eric: review-
DetailsFormatted DiffDiff
Port systemBeep to BREW (2.60 KB, patch)
2010-01-26 17:07 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-13 08:35:07 PST
Created attachment 46468 [details] Port systemBeep to BREW
Kwang Yul Seo
Comment 2 2010-01-25 01:55:59 PST
Created attachment 47329 [details] Port systemBeep to BREW
Eric Seidel (no email)
Comment 3 2010-01-26 14:51:50 PST
Comment on attachment 47329 [details] Port systemBeep to BREW Looks OK except for: 29 #undef COMPILE_ASSERT
Kwang Yul Seo
Comment 4 2010-01-26 17:07:34 PST
Created attachment 47468 [details] Port systemBeep to BREW Remove COMPILE_ASSERT.
Eric Seidel (no email)
Comment 5 2010-02-01 15:30:30 PST
Comment on attachment 47468 [details] Port systemBeep to BREW OK.
WebKit Commit Bot
Comment 6 2010-02-02 03:54:46 PST
Comment on attachment 47468 [details] Port systemBeep to BREW Clearing flags on attachment: 47468 Committed r54223: <http://trac.webkit.org/changeset/54223>
WebKit Commit Bot
Comment 7 2010-02-02 03:54:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.