Summary: | [Android] Bridge interfaces Field, Class, Instance and Array use JSC-specific types | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||||||||
Component: | WebCore Misc. | Assignee: | Steve Block <steveblock> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | android-webkit-unforking, gustavo, steveblock, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Android | ||||||||||||
OS: | Android | ||||||||||||
Bug Depends on: | 33801 | ||||||||||||
Bug Blocks: | 32154 | ||||||||||||
Attachments: |
|
Description
Steve Block
2010-01-13 04:33:42 PST
Created attachment 46455 [details] Patch 1 for Bug 33589 Attachment 46455 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/185336 Attachment 46455 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/185344 Created attachment 46472 [details] Patch 2 for Bug 33589 Fixes qt and gtk builds Attachment 46472 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/184509 Created attachment 46561 [details] Patch 3 for Bug 33589 Second attempt to fix qt build. (In reply to comment #6) > Created an attachment (id=46561) [details] > Patch 3 for Bug 33589 > > Second attempt to fix qt build. The fix for this bug will involve splitting runtime.[cpp|h] into generic and JSC-specific parts. It's probably best to fix the naming of runtime.[cpp|h] first, so I've opened Bug 33801 as part of Bug 33712 Created attachment 47023 [details] Patch 4 for Bug 33589 Updated patch now that runtime.[cpp|h] has been renamed to Bridge.[cpp|h] Comment on attachment 47023 [details] Patch 4 for Bug 33589 > Index: WebCore/bridge/Bridge.h > - * Copyright (C) 2003, 2008, 2009 Apple Inc. All rights reserved. > + * Copyright (C) 2003, 2008, 2009, 2010 Apple Inc. All rights reserved. It seems odd to add 2010 to the Apple copyright. I think you should add your own. > +#if USE(JSC) > +#include "BridgeJSC.h" > +#endif It seems that the preferred pattern is to put the if in the header itself and just include it unconditionally. Addressed all comments Landed manually as http://trac.webkit.org/changeset/53620 Closing bug as resolved |