Bug 33582

Summary: [BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, eric, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
MarkStack for platforms without page allocation
none
MarkStack for platforms without page allocation
none
MarkStack for platforms without page allocation none

Description Kwang Yul Seo 2010-01-13 02:06:05 PST 
Use fastMalloc and fastFree to implement MarkStack::allocateStack and MarkStack::releaseStack respectively. Set to the page size to 4096.
Comment 1 Kwang Yul Seo 2010-01-13 02:10:25 PST 
Created attachment 46437 [details]
MarkStack for platforms without page allocation
Comment 2 WebKit Review Bot 2010-01-13 02:12:04 PST 
Attachment 46437 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/MarkStackNone.cpp:28:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 1
Comment 3 Kwang Yul Seo 2010-01-13 02:15:31 PST 
Created attachment 46438 [details]
MarkStack for platforms without page allocation

Fix style errors.
Comment 4 Kwang Yul Seo 2010-01-25 01:51:44 PST 
Created attachment 47328 [details]
MarkStack for platforms without page allocation

Use PLATFORM(BREWMP)
Comment 5 Eric Seidel (no email) 2010-01-26 14:50:34 PST 
I don't really know what these functions are for, so I don't know if this is sane.
Comment 6 Oliver Hunt 2010-01-26 15:14:34 PST 
Comment on attachment 47328 [details]
MarkStack for platforms without page allocation

r=me
Comment 7 WebKit Commit Bot 2010-01-27 04:44:03 PST 
Comment on attachment 47328 [details]
MarkStack for platforms without page allocation

Clearing flags on attachment: 47328

Committed r53922: <http://trac.webkit.org/changeset/53922>
Comment 8 WebKit Commit Bot 2010-01-27 04:44:09 PST 
All reviewed patches have been landed.  Closing bug.