Bug 33579

Summary: Web Inspector: speed-up Timeline panel scrolling
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch file with changes in TimelinePanel.js and WebCore/ChangeLog
pfeldman: review-
Patch for TimelinePanel.js. Style was adjusted a bit. Problem with overview pane was fixed.
pfeldman: review-
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added.
none
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.
none
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.
none
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed. none

Description Ilya Tikhonovsky 2010-01-13 00:29:52 PST 
Timeline's panel scrolling speed can be increased.

updateDividers function should not to be invoked in the process of scrolling.
~30% of rendering time will be saved.
Comment 1 Ilya Tikhonovsky 2010-01-13 01:54:06 PST 
Created attachment 46436 [details]
Patch file with changes in TimelinePanel.js and WebCore/ChangeLog
Comment 2 Pavel Feldman 2010-01-13 02:08:21 PST 
Comment on attachment 46436 [details]
Patch file with changes in TimelinePanel.js and WebCore/ChangeLog

Looks good. Few suggestions on the naming before it lands:

> +    this._updateBoundaries = false;

this._updateBoundaries -> this._boundariesAreValid (and inverse the meaning)

>  
>      _scheduleRefresh: function(immediate)
>      {

immediate -> preserveBoundaries

> +    _refreshRecords: function(updateBoundaries)
Comment 3 Ilya Tikhonovsky 2010-01-13 06:47:15 PST 
Created attachment 46454 [details]
Patch for TimelinePanel.js. Style was adjusted a bit. Problem with overview pane was fixed.
Comment 4 Pavel Feldman 2010-01-13 07:08:31 PST 
Comment on attachment 46454 [details]
Patch for TimelinePanel.js. Style was adjusted a bit. Problem with overview pane was fixed.

> + this._boundariesAreValid &= preserveBoundaries

You did not initialize this._boundariesAreValid field. Otherwise r+
Comment 5 Ilya Tikhonovsky 2010-01-13 07:30:02 PST 
Created attachment 46458 [details]
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added.
Comment 6 Ilya Tikhonovsky 2010-01-13 07:42:54 PST 
Created attachment 46460 [details]
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.
Comment 7 WebKit Review Bot 2010-01-13 07:43:51 PST 
Attachment 46460 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1
Comment 8 Ilya Tikhonovsky 2010-01-13 07:47:05 PST 
Created attachment 46461 [details]
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.
Comment 9 Ilya Tikhonovsky 2010-01-13 07:52:37 PST 
Created attachment 46462 [details]
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.
Comment 10 WebKit Commit Bot 2010-01-13 08:32:01 PST 
Comment on attachment 46462 [details]
Patch has changes for TimelinePanel.js. The initialization of _boundariesAreValid was added. ChangeLog was fixed.

Clearing flags on attachment: 46462

Committed r53188: <http://trac.webkit.org/changeset/53188>
Comment 11 WebKit Commit Bot 2010-01-13 08:32:09 PST 
All reviewed patches have been landed.  Closing bug.