Bug 33577

Summary: [BREWMP] Don't use time function
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Replace time(0) with currentTime() for BREW
none
Replace time(0) with currentTime() for BREW
none
Replace time(0) with currentTime() none

Kwang Yul Seo
Reported 2010-01-12 23:34:09 PST
Calling time(0) in BREW devices causes a crash because time is not ported properly. Cast currentTime to int to get the same result as time(0).
Attachments
Replace time(0) with currentTime() for BREW (1.19 KB, patch)
2010-01-12 23:37 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Replace time(0) with currentTime() for BREW (1.21 KB, patch)
2010-01-12 23:44 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Replace time(0) with currentTime() (1.22 KB, patch)
2010-01-22 21:49 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-12 23:37:10 PST
Created attachment 46428 [details] Replace time(0) with currentTime() for BREW
Kwang Yul Seo
Comment 2 2010-01-12 23:44:47 PST
Created attachment 46429 [details] Replace time(0) with currentTime() for BREW ChangeLog.
Kwang Yul Seo
Comment 3 2010-01-22 21:49:25 PST
Created attachment 47265 [details] Replace time(0) with currentTime()
Eric Seidel (no email)
Comment 4 2010-01-26 14:47:56 PST
Comment on attachment 47265 [details] Replace time(0) with currentTime() I do not know if this is correct. It looks non-harmful though.
WebKit Commit Bot
Comment 5 2010-01-27 04:17:48 PST
Comment on attachment 47265 [details] Replace time(0) with currentTime() Clearing flags on attachment: 47265 Committed r53921: <http://trac.webkit.org/changeset/53921>
WebKit Commit Bot
Comment 6 2010-01-27 04:17:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.