Bug 33577

Summary: [BREWMP] Don't use time function
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Replace time(0) with currentTime() for BREW
none
Replace time(0) with currentTime() for BREW
none
Replace time(0) with currentTime() none

Description Kwang Yul Seo 2010-01-12 23:34:09 PST 
Calling time(0) in BREW devices causes a crash because time is not ported properly. Cast currentTime to int to get the same result as time(0).
Comment 1 Kwang Yul Seo 2010-01-12 23:37:10 PST 
Created attachment 46428 [details]
Replace time(0) with currentTime() for BREW
Comment 2 Kwang Yul Seo 2010-01-12 23:44:47 PST 
Created attachment 46429 [details]
Replace time(0) with currentTime() for BREW

ChangeLog.
Comment 3 Kwang Yul Seo 2010-01-22 21:49:25 PST 
Created attachment 47265 [details]
Replace time(0) with currentTime()
Comment 4 Eric Seidel (no email) 2010-01-26 14:47:56 PST 
Comment on attachment 47265 [details]
Replace time(0) with currentTime()

I do not know if this is correct.  It looks non-harmful though.
Comment 5 WebKit Commit Bot 2010-01-27 04:17:48 PST 
Comment on attachment 47265 [details]
Replace time(0) with currentTime()

Clearing flags on attachment: 47265

Committed r53921: <http://trac.webkit.org/changeset/53921>
Comment 6 WebKit Commit Bot 2010-01-27 04:17:53 PST 
All reviewed patches have been landed.  Closing bug.