Bug 33569

Summary: [BREWMP] Add dummy main thread functions
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Add dummy main thread functions
none
Add dummy main thread functions none

Kwang Yul Seo
Reported 2010-01-12 19:34:21 PST
Add dummy initializeMainThreadPlatform and scheduleDispatchFunctionsOnMainThread.
Attachments
Add dummy main thread functions (2.78 KB, patch)
2010-01-12 19:38 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Add dummy main thread functions (2.77 KB, patch)
2010-01-25 01:45 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-12 19:38:34 PST
Created attachment 46421 [details] Add dummy main thread functions
Kwang Yul Seo
Comment 2 2010-01-25 01:45:54 PST
Created attachment 47327 [details] Add dummy main thread functions BREW -> BREWMP in ChangeLog
Eric Seidel (no email)
Comment 3 2010-01-26 14:44:46 PST
Comment on attachment 47327 [details] Add dummy main thread functions Why does brew not need these? Will BREW not be using mutli-threaded JS, or storage?
Eric Seidel (no email)
Comment 4 2010-01-26 14:45:08 PST
Comment on attachment 47327 [details] Add dummy main thread functions Removing cq+ pending further explanation of "why" this is correct.
Kwang Yul Seo
Comment 5 2010-01-27 09:43:27 PST
Currently, the BREW MP port is single-threaded and does not use features which require multi-threading. As BREW (not BREW MP) does not provide pre-emptive multi-threading, I made the port single-threaded to make it backward compatible with BREW. With new IThread1 interface provided by BREW MP, now it is possible to implement pre-emptive multi-theading. I will add multi-threading support to BREW MP once this initial review process is finished.
WebKit Commit Bot
Comment 6 2010-02-02 14:34:22 PST
Comment on attachment 47327 [details] Add dummy main thread functions Clearing flags on attachment: 47327 Committed r54255: <http://trac.webkit.org/changeset/54255>
WebKit Commit Bot
Comment 7 2010-02-02 14:34:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.