Bug 33566

Summary: [BREWMP] Port WTF's randomNumber
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Port randomNumber and weakRandomNumber to BREW
none
Port randomNumber and weakRandomNumber
eric: review-
Port randomNumber and weakRandomNumber
eric: review+, eric: commit-queue-
Port randomNumber and weakRandomNumber none

Kwang Yul Seo
Reported 2010-01-12 17:54:08 PST
1. Use GETRAND to generate 4 byte random byte sequence to implement weakRandomNumber. 2. Create a secure random number generator with AEECLSID_RANDOM to implement randomNumber.
Attachments
Port randomNumber and weakRandomNumber to BREW (2.42 KB, patch)
2010-01-12 17:58 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Port randomNumber and weakRandomNumber (2.42 KB, patch)
2010-01-22 18:04 PST, Kwang Yul Seo 		eric: review-
DetailsFormatted DiffDiff
Port randomNumber and weakRandomNumber (2.39 KB, patch)
2010-01-26 16:14 PST, Kwang Yul Seo 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Port randomNumber and weakRandomNumber (2.39 KB, patch)
2010-01-26 16:58 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-12 17:58:39 PST
Created attachment 46417 [details] Port randomNumber and weakRandomNumber to BREW
Kwang Yul Seo
Comment 2 2010-01-22 18:04:46 PST
Created attachment 47252 [details] Port randomNumber and weakRandomNumber
Eric Seidel (no email)
Comment 3 2010-01-26 14:41:39 PST
Comment on attachment 47252 [details] Port randomNumber and weakRandomNumber Seems we should add the #undef to wtf/Assertions.h instead: Something like what we do for windows: #if OS(WINDOWS) || OS(SYMBIAN) /* FIXME: Change to use something other than ASSERT to avoid this conflict with the underlying platform */ #undef ASSERT #endif
Eric Seidel (no email)
Comment 4 2010-01-26 14:41:50 PST
Otherwise the patch looks sane enough.
Kwang Yul Seo
Comment 5 2010-01-26 16:14:42 PST
Created attachment 47458 [details] Port randomNumber and weakRandomNumber Remove #undef COMPILE_ASSERT. I will file a bug for "#undef COMPILE_ASSERT".
Eric Seidel (no email)
Comment 6 2010-01-26 16:47:28 PST
Comment on attachment 47458 [details] Port randomNumber and weakRandomNumber Looks fine. Can't be cq+'d because it fails to apply. Did you edit the diff manually? That will commonly cause apply failures, as it's difficult to do correctly. Easiest is to just generate a new diff using the tools.
Kwang Yul Seo
Comment 7 2010-01-26 16:58:00 PST
Created attachment 47463 [details] Port randomNumber and weakRandomNumber I generated a new diff with the tools.
Eric Seidel (no email)
Comment 8 2010-01-26 17:52:56 PST
Comment on attachment 47463 [details] Port randomNumber and weakRandomNumber Looks OK.
WebKit Commit Bot
Comment 9 2010-01-27 06:08:05 PST
Comment on attachment 47463 [details] Port randomNumber and weakRandomNumber Clearing flags on attachment: 47463 Committed r53928: <http://trac.webkit.org/changeset/53928>
WebKit Commit Bot
Comment 10 2010-01-27 06:08:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.