Summary: | [BREWMP] Port WTF's randomNumber | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | Other | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 33564 | ||||||||||||
Attachments: |
|
Description
Kwang Yul Seo
2010-01-12 17:54:08 PST
Created attachment 46417 [details]
Port randomNumber and weakRandomNumber to BREW
Created attachment 47252 [details]
Port randomNumber and weakRandomNumber
Comment on attachment 47252 [details]
Port randomNumber and weakRandomNumber
Seems we should add the #undef to wtf/Assertions.h instead:
Something like what we do for windows:
#if OS(WINDOWS) || OS(SYMBIAN)
/* FIXME: Change to use something other than ASSERT to avoid this conflict with the underlying platform */
#undef ASSERT
#endif
Otherwise the patch looks sane enough. Created attachment 47458 [details]
Port randomNumber and weakRandomNumber
Remove #undef COMPILE_ASSERT. I will file a bug for "#undef COMPILE_ASSERT".
Comment on attachment 47458 [details]
Port randomNumber and weakRandomNumber
Looks fine. Can't be cq+'d because it fails to apply. Did you edit the diff manually? That will commonly cause apply failures, as it's difficult to do correctly. Easiest is to just generate a new diff using the tools.
Created attachment 47463 [details]
Port randomNumber and weakRandomNumber
I generated a new diff with the tools.
Comment on attachment 47463 [details]
Port randomNumber and weakRandomNumber
Looks OK.
Comment on attachment 47463 [details] Port randomNumber and weakRandomNumber Clearing flags on attachment: 47463 Committed r53928: <http://trac.webkit.org/changeset/53928> All reviewed patches have been landed. Closing bug. |