Bug 33563 – Transition followed by animation fails to run the animation sometimes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Created attachment 46416 [details]
Testcase

The attached testcase shows an issue where, if a transition fires at the same time as an animation starts, and if the animation has an animation-delay similar to the duration of the transition, then sometimes the animation fails to run (with hardware accel.).

[Simon Fraser (smfr)]

<rdar://problem/7535633>

[Simon Fraser (smfr)]

Created attachment 46501 [details]
Patch

[Darin Adler]

Comment on attachment 46501 [details]
Patch

> +        Fix this by including they keyframes name (or empty string for transitions) in the labels

Typo: "they keyframes"

> +        * platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signataure changes.

Typo: "signataure"

> +    void setAnimationOnLayer(CAPropertyAnimation*, AnimatedPropertyID, const String&, int index, double timeOffset);
> +    bool removeAnimationFromLayer(AnimatedPropertyID, const String&, int index);
> +    void pauseAnimationOnLayer(AnimatedPropertyID, const String&, int index, double timeOffset);

I think these new string arguments need an argument name for clarity.

>      String animationId = propertyIdToString(property);
>      animationId.append("_");
> +    if (!keyframesName.isEmpty()) {
> +        animationId.append(keyframesName);
> +        animationId.append("_");
> +    }
> +    animationId.append("_");
>      animationId.append(String::number(index));

This function is using an inefficient idiom for building a String. The String class allocates a new buffer every time you append to it. You should use StringBuilder or Vector<UChar> or some other alternate strategy.

r=me

[Simon Fraser (smfr)]

Committed with review comments addressed:
http://trac.webkit.org/changeset/53236