Bug 33543

Summary: fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 33292    
Attachments:
Description Flags
Patch dglazkov: review+, commit-queue: commit-queue-

Eric Seidel (no email)
Reported 2010-01-12 11:52:58 PST
fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot I assume it's just flakey. http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r53145%20(3366)/fast/forms/search-event-delay-diffs.txt --- layout-test-results/fast/forms/search-event-delay-expected.txt 2010-01-12 10:33:47.000000000 -0800 +++ layout-test-results/fast/forms/search-event-delay-actual.txt 2010-01-12 10:33:47.000000000 -0800 @@ -6,4 +6,4 @@ The two rows below should match. 0.5 0.4 0.3 0.2 0.2 0 -0.5 0.4 0.3 0.2 0.2 0 +0.5 0.5 0.3 0.2 0.2 0 This test has been around for 2 years. Originally written by ap: http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/search-event-delay.html
Attachments
Patch (1.44 KB, patch)
2010-01-24 23:51 PST, Eric Seidel (no email) 		dglazkov: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-01-12 12:22:08 PST
> This test has been around for 2 years. Originally written by ap: It was not. <http://trac.webkit.org/changeset/19336/trunk/LayoutTests/fast/forms/search-event-delay.html>
Eric Seidel (no email)
Comment 2 2010-01-12 12:36:21 PST
One day I'll learn to read trac. :(
Eric Seidel (no email)
Comment 4 2010-01-12 15:36:09 PST
I expect this has been flakey for a while, but that SL Debug Bot has just been so red with other stuff we haven't noticed.
Eric Seidel (no email)
Comment 6 2010-01-24 23:43:55 PST
Same test, different diff this time: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r53793%20(3694)/fast/forms/search-event-delay-diffs.txt --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/layout-test-results/fast/forms/search-event-delay-expected.txt 2010-01-24 23:18:40.000000000 -0800 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/layout-test-results/fast/forms/search-event-delay-actual.txt 2010-01-24 23:18:40.000000000 -0800 @@ -6,4 +6,4 @@ The two rows below should match. 0.5 0.4 0.3 0.2 0.2 0 -0.5 0.4 0.3 0.2 0.2 0 +0.6 0.4 0.3 0.2 0.2 0
Eric Seidel (no email)
Comment 7 2010-01-24 23:44:40 PST
this test should instead print PASS fail if the numbers are within a certain threshold.
Eric Seidel (no email)
Comment 8 2010-01-24 23:51:15 PST
Created attachment 47318 [details] Patch
Dimitri Glazkov (Google)
Comment 9 2010-02-17 20:16:23 PST
Comment on attachment 47318 [details] Patch ok.
WebKit Commit Bot
Comment 10 2010-02-17 23:01:10 PST
Comment on attachment 47318 [details] Patch Rejecting patch 47318 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac-snowleopard/Skipped Hunk #1 FAILED at 82. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-snowleopard/Skipped.rej Full output: http://webkit-commit-queue.appspot.com/results/282165
Eric Seidel (no email)
Comment 11 2010-02-19 16:23:01 PST
Attachment 47318 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 12 2010-02-19 16:51:34 PST
Committed r55040: <http://trac.webkit.org/changeset/55040>
Note You need to log in before you can comment on or make changes to this bug.