Bug 33521

Summary:

webkit-patch shouldn't waste my time for with a component prompt

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, eric, mjs

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Adam Barth

Reported 2010-01-11 23:38:19 PST

webkit-patch shouldn't waste my time for with a component prompt

Attachments
Patch (1.62 KB, patch) 2010-01-11 23:39 PST, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-01-11 23:39:51 PST

Created attachment 46339 [details] Patch

Eric Seidel (no email)

Comment 2 2010-01-11 23:41:08 PST

Comment on attachment 46339 [details] Patch LGTM.

Adam Barth

Comment 3 2010-01-12 01:41:45 PST

Comment on attachment 46339 [details] Patch Clearing flags on attachment: 46339 Committed r53121: <http://trac.webkit.org/changeset/53121>

Adam Barth

Comment 4 2010-01-12 01:41:51 PST

All reviewed patches have been landed. Closing bug.

David Kilzer (:ddkilzer)

Comment 5 2010-01-15 12:41:41 PST

This change in behavior will make it harder to find bugs by component in the future. Is there still a way to get the component prompted for if you want to fill it out?

Adam Barth

Comment 6 2010-01-15 13:15:41 PST

> Is there still a way to get the component prompted for if you want to fill it > out? You can specify it on the command line using the --component flag. If you'd like it to prompt you, can can pass --component=prompt (or actually any bogus value).

Note You need to log in before you can comment on or make changes to this bug.