Bug 33501

Summary: [chromium] FontLinux::selectionRectForComplexText can assert when TextRun gets normalized
Product: WebKit Reporter: John Gregg <johnnyg>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: hbono, jshin, yusukes
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

John Gregg
Reported 2010-01-11 16:22:32 PST
This bug causes LayoutTests/fast/text/find-kana.html to assert in the following way: When a find is *successful* on a string with U+0300 character, chromium updates the selection and Font::selectionRectForComplexText(run, point, height, from, to) is called with run={length: 3, ...}, from=0, to=3, but the TextRunWalker walker(run) gets normalized so that walker={length: 2}, from=0, to=3, and we essentially hit an out-of-bounds problem when working with the walker. I think the correct fix is to not normalize in this case; I will submit a patch for this.
Attachments
Patch (3.97 KB, patch)
2010-01-11 18:01 PST, John Gregg 		no flags
DetailsFormatted DiffDiff
Patch (3.98 KB, patch)
2010-01-11 18:07 PST, John Gregg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Gregg
Comment 1 2010-01-11 18:01:14 PST
Created attachment 46326 [details] Patch
John Gregg
Comment 2 2010-01-11 18:07:40 PST
Created attachment 46327 [details] Patch
John Gregg
Comment 3 2010-01-11 18:13:30 PST
CC+ hbono
Jungshik Shin
Comment 4 2010-03-05 10:53:51 PST
The normalization was added by Yusuke with my review (in r47922). (bug 28742). The patch looks ok, but I'm not sure.
Stephen Chenney
Comment 5 2013-04-09 16:09:38 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.
Note You need to log in before you can comment on or make changes to this bug.