Bug 33485

Summary:

Erroneous macro usage in navigator platform

Product:

WebKit

Reporter:

Christian Dywan <christian>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

mjs

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Use DARWIN to determine Mac builds	darin: review-
Use DARWIN in the GTK+ specific WebKitWebSettings as well	darin: review-

Christian Dywan

Reported 2010-01-11 12:23:09 PST

As far as I'm aware the MAC macro in WebCore is only defined on the Mac/ Cocoa port, but it is used in code paths that affect non-native Mac builds in identifying the navigator platform. So I think DARWIN should be used to identify "Intel Mac OS X" and "PPC Mac OS X" accordingly.

Attachments
Use DARWIN to determine Mac builds (605 bytes, patch) 2010-01-11 12:24 PST, Christian Dywan	darin: review-	Details Formatted Diff Diff
Use DARWIN in the GTK+ specific WebKitWebSettings as well (950 bytes, patch) 2010-01-11 12:25 PST, Christian Dywan	darin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Christian Dywan

Comment 1 2010-01-11 12:24:18 PST

Created attachment 46298 [details] Use DARWIN to determine Mac builds

Christian Dywan

Comment 2 2010-01-11 12:25:21 PST

Created attachment 46299 [details] Use DARWIN in the GTK+ specific WebKitWebSettings as well

Darin Adler

Comment 3 2010-01-11 13:52:34 PST

Comment on attachment 46298 [details] Use DARWIN to determine Mac builds Needs ChangeLog. No effect on Mac OS X WebKit, but have you consulted with folks on platforms like GTK, Qt, and Chromium? Do they all agree this change is what they would like to see?

Darin Adler

Comment 4 2010-01-11 13:52:50 PST

Comment on attachment 46299 [details] Use DARWIN in the GTK+ specific WebKitWebSettings as well Needs ChangeLog.

Note You need to log in before you can comment on or make changes to this bug.