Bug 33465

Summary: [Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, kim.1.gronholm, koivisto
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Fix fast/events/touch/touch-coords-in-zoom-and-scroll.html none

Description Csaba Osztrogonác 2010-01-11 03:38:33 PST
fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html introduced in r53069 fails on QtBuildBot

r53069: http://trac.webkit.org/changeset/53069
pretty diff: http://build.webkit.org/results/Qt%20Linux%20Release/r53069%20%285820%29/fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html

--- layout-test-results/fast/events/touch-coords-in-zoom-and-scroll-expected.txt	2010-01-11 01:57:34.000000000 -0800
+++ layout-test-results/fast/events/touch-coords-in-zoom-and-scroll-actual.txt	2010-01-11 01:57:34.000000000 -0800
@@ -1,26 +1,3 @@
-Base
-PASS event.touches[0].clientX is 100
-PASS event.touches[0].clientY is 100
-PASS event.touches[0].pageX is 100
-PASS event.touches[0].pageY is 100
-
-Just zoomed
-PASS event.touches[0].clientX is 83
-PASS event.touches[0].clientY is 83
-PASS event.touches[0].pageX is 83
-PASS event.touches[0].pageY is 83
-
-Just scrolled
-PASS event.touches[0].clientX is 100
-PASS event.touches[0].clientY is 100
-PASS event.touches[0].pageX is 150
-PASS event.touches[0].pageY is 150
-
-Zoomed and scrolled
-PASS event.touches[0].clientX is 84
-PASS event.touches[0].clientY is 84
-PASS event.touches[0].pageX is 133
-PASS event.touches[0].pageY is 133
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Csaba Osztrogonác 2010-01-11 03:50:26 PST
fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped by http://trac.webkit.org/changeset/53071 until fix. (to make buildbot happy)
Comment 2 Petri Latvala 2010-01-12 06:04:37 PST
Created attachment 46366 [details]
Fix fast/events/touch/touch-coords-in-zoom-and-scroll.html

The problem was introduced by the patch in https://bugs.webkit.org/show_bug.cgi?id=32878. If none of the touch points actually moved, a touchmove event is not dispatched at all. Changed the test to use touchstart instead.
Comment 3 WebKit Commit Bot 2010-01-12 06:37:27 PST
Comment on attachment 46366 [details]
Fix fast/events/touch/touch-coords-in-zoom-and-scroll.html

Clearing flags on attachment: 46366

Committed r53140: <http://trac.webkit.org/changeset/53140>
Comment 4 WebKit Commit Bot 2010-01-12 06:37:34 PST
All reviewed patches have been landed.  Closing bug.