Bug 33414

Summary: Let webkit-patch work with options in $EDITOR
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2010-01-08 18:12:34 PST
Let webkit-patch work with options in $EDITOR
Attachments
Patch (1.16 KB, patch)
2010-01-08 18:13 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.17 KB, patch)
2010-01-08 18:23 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.27 KB, patch)
2010-01-09 10:01 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-08 18:13:33 PST
Created attachment 46188 [details] Patch
WebKit Review Bot
Comment 2 2010-01-08 18:18:33 PST
Attachment 46188 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2
Adam Barth
Comment 3 2010-01-08 18:23:14 PST
Created attachment 46189 [details] Patch
Adam Barth
Comment 4 2010-01-08 18:23:50 PST
Interesting failure mode. We're checking style before editing the changelog. :)
Mark Rowe (bdash)
Comment 5 2010-01-09 03:32:47 PST
This naive approach will do the wrong thing if the path to your editor’s binary happens to contain a space. <http://subversion.tigris.org/faq.html#svn-editor> talks about how SVN handles this. Python’s shlex module may be useful to address this.
Adam Barth
Comment 6 2010-01-09 09:58:23 PST
Comment on attachment 46189 [details] Patch Good point. I looked around for a python module to help, but I couldn't find one. shlex looks perfect.
Adam Barth
Comment 7 2010-01-09 10:01:41 PST
Created attachment 46211 [details] Patch
Eric Seidel (no email)
Comment 8 2010-01-09 15:48:17 PST
Comment on attachment 46211 [details] Patch Sweet! Seems we need a test case though. One should be very easy to write, no?
Adam Barth
Comment 9 2010-01-09 16:44:50 PST
It's hard to write a test case because this code is calling system APIs directly. We could introduce another abstraction layer, but the point of this code is to be the abstraction layer around these APIs...
Darin Adler
Comment 10 2010-01-10 20:49:23 PST
Comment on attachment 46211 [details] Patch rs=me
WebKit Commit Bot
Comment 11 2010-01-10 21:11:28 PST
Comment on attachment 46211 [details] Patch Clearing flags on attachment: 46211 Committed r53063: <http://trac.webkit.org/changeset/53063>
WebKit Commit Bot
Comment 12 2010-01-10 21:11:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.